Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing device in fake operator #2203

Closed
wants to merge 1 commit into from
Closed

Conversation

TroyGarden
Copy link
Contributor

Summary:

context

  • when we have the input tensors on the meta device, it calls the fake operator
  • however the device information is unintentionally missed so the output tensor is on the default device (cpu)
  • this is an incorrect behavior

Reviewed By: gnahzg, iamzainhuda

Differential Revision: D57077813

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 3, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57077813

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57077813

TroyGarden added a commit that referenced this pull request Jul 3, 2024
Summary:
Pull Request resolved: #2203

# context
* when we have the input tensors on the meta device, it calls the fake operator
* however the device information is unintentionally missed so the output tensor is on the default device (cpu)
* this is an incorrect behavior

Reviewed By: gnahzg, iamzainhuda

Differential Revision: D57077813
Summary:
Pull Request resolved: #2203

# context
* when we have the input tensors on the meta device, it calls the fake operator
* however the device information is unintentionally missed so the output tensor is on the default device (cpu)
* this is an incorrect behavior

Reviewed By: gnahzg, iamzainhuda

Differential Revision: D57077813
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57077813

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants