tag KJT related part to sc.INPUT_DIST #2678
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: tag KJT output to sc.INPUT_DIST to enforce placement on CPU Differential Revision: D67313214
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67313214 |
jingsh
reviewed
Jan 14, 2025
| @@ -300,6 +300,23 @@ def _fx_trec_unwrap_kjt( | |||
| return indices.int(), offsets.int() | |||
|
|
|||
|
|
|||
| @torch.fx.wrap | |||
jingsh
approved these changes
Jan 14, 2025
Comment on lines
+309
to
+310
| CPU - int32 or int64, offsets dtype must match | ||
| GPU - int32 only, offsets dtype must match |
There was a problem hiding this comment.
can you provide reference on this dtype?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: tag KJT output to sc.INPUT_DIST to enforce placement on CPU
Differential Revision: D67313214