Teach is_signature_compatible() to dig into similar annotations #2693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68475380 |
…rch#2693) Summary: D68450007 updated some annotations in pytorch. This function wasn't correctly evaluating `typing.Dict[X, Y]` and `dict[X, Y]` as the equivalent. Differential Revision: D68475380
aorenste
force-pushed
the
export-D68475380
branch
from
d8a6f7a to
3460897
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68475380 |
izaitsevfb
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
forward fix for pytorch/pytorch#145175
failures are on trunk
PaulZhang12
pushed a commit
that referenced
this pull request
Jan 28, 2025
Summary: Pull Request resolved: #2693 D68450007 updated some annotations in pytorch. This function wasn't correctly evaluating `typing.Dict[X, Y]` and `dict[X, Y]` as the equivalent. Reviewed By: izaitsevfb Differential Revision: D68475380 fbshipit-source-id: 3b71ab41f95e6c20986ebe6fbf6f9cbe3b3d58f9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: D68450007 updated some annotations in pytorch. This function wasn't correctly evaluating
typing.Dict[X, Y]anddict[X, Y]as the equivalent.Differential Revision: D68475380