Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix pyre issue in planner/ proposers.py #2752

Closed
wants to merge 1 commit into from
Closed

fix pyre issue in planner/ proposers.py #2752

wants to merge 1 commit into from

Conversation

TroyGarden
Copy link
Contributor

Summary:

context

pushd ~/local
conda create -n pyre python=3.9
conda activate pyre
git clone https://github.com/pytorch/torchrec.git
pushd torchrec
          pip install torch --index-url https://download.pytorch.org/whl/nightly/cpu &&
          pip install fbgemm-gpu --index-url https://download.pytorch.org/whl/nightly/cpu &&
          pip install -r requirements.txt &&
          pip install pyre-check-nightly==$(cat .pyre_configuration | grep version | awk '{print $2}' | sed 's/\"//g')
pyre check

Differential Revision: D69834157

@TroyGarden @facebook-github-bot
fix pyre issue
d681caa 
Summary:
# context
* the pyre test for the main branch has been broken for a while: https://github.com/pytorch/torchrec/actions/runs/13403865364/job/37441635200
* reproduced this issue locally by the following commands. [conf](https://github.com/pytorch/torchrec/blob/main/.github/workflows/pyre.yml)
```
pushd ~/local
conda create -n pyre python=3.9
conda activate pyre
git clone https://github.com/pytorch/torchrec.git
pushd torchrec
          pip install torch --index-url https://download.pytorch.org/whl/nightly/cpu &&
          pip install fbgemm-gpu --index-url https://download.pytorch.org/whl/nightly/cpu &&
          pip install -r requirements.txt &&
          pip install pyre-check-nightly==$(cat .pyre_configuration | grep version | awk '{print $2}' | sed 's/\"//g')
pyre check
```

Differential Revision: D69834157
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 19, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69834157

@TroyGarden TroyGarden changed the title fix pyre issue fix pyre issue in planner/ proposers.py Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TroyGarden @facebook-github-bot