fix pre-commit error in sharding #2755
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69905081 |
TroyGarden
force-pushed
the
export-D69905081
branch
from
4da4554 to
7e888b6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69905081 |
Summary: # context * TorchRec's OSS workflow "build dynamic embedding wheels" has been [failing](https://github.com/pytorch/torchrec/actions/runs/13416363464/job/37478091546) due to an upgrading of upload action [bug report](actions/upload-artifact#506) * we saw similar error message as below ``` Run actions/upload-artifact@v4 With the provided path, there will be 1 file uploaded Artifact name is valid! Root directory input is valid! Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run ``` # solution * as described in this [migration.md](https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md), adding additional job (merge) the artifacts. Differential Revision: D69904715
Summary: # context * pre-commit test failed: https://github.com/pytorch/torchrec/actions/runs/13416363381/job/37489987778 * after the fix {F1975288470} Differential Revision: D69905081
TroyGarden
force-pushed
the
export-D69905081
branch
from
7e888b6 to
8015490
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69905081 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
context
Differential Revision: D69905081