Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TorchTitan] Add destory process group at the end of training #223

Merged
merged 7 commits into from
Apr 12, 2024
Merged

[TorchTitan] Add destory process group at the end of training #223

merged 7 commits into from
Apr 12, 2024

Conversation

wz337
Copy link
Contributor

@wz337 wz337 commented Apr 12, 2024

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Apr 12, 2024
@wz337 wz337 marked this pull request as ready for review April 12, 2024 00:23
@wz337 wz337 requested a review from wconstab April 12, 2024 00:25
Copy link
Contributor

@lessw2020 lessw2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!
I tested with this and seems it resolves the random errors at end of training I've been seeing.
Thanks for the PR!

@wz337 wz337 merged commit c0b5ce2 into pytorch:main Apr 12, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants