Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polish toml files and helper messages #245

Merged
merged 4 commits into from
Apr 16, 2024

Conversation

tianyu-l
Copy link
Contributor

@tianyu-l tianyu-l commented Apr 16, 2024

Stack from ghstack (oldest at bottom):

[ghstack-poisoned]
tianyu-l added a commit that referenced this pull request Apr 16, 2024
ghstack-source-id: b970e2f9ef1f042b76c48d557a151b14bc5000ca
Pull Request resolved: #245
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Apr 16, 2024
Copy link
Contributor

@lessw2020 lessw2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. I'm not sure if it will be noticed but nice to have everything fully polished.

[ghstack-poisoned]
tianyu-l added a commit that referenced this pull request Apr 16, 2024
ghstack-source-id: 0e9527d84d70bc1a2aeb68b49eae938c56e7220d
Pull Request resolved: #245
[ghstack-poisoned]
tianyu-l added a commit that referenced this pull request Apr 16, 2024
ghstack-source-id: 7c7024ca437fbfc95e22eace5924d27773f33640
Pull Request resolved: #245
@tianyu-l tianyu-l changed the title polish toml files polish toml files and helper messages Apr 16, 2024
@tianyu-l
Copy link
Contributor Author

also polishing helper messages...

tianyu-l added a commit that referenced this pull request Apr 16, 2024
ghstack-source-id: 287d31e9a14861244f1292f61604a296fb7d4e11
Pull Request resolved: #245
@tianyu-l tianyu-l merged commit a3df3c5 into gh/tianyu-l/9/base Apr 16, 2024
4 checks passed
tianyu-l added a commit that referenced this pull request Apr 16, 2024
ghstack-source-id: 287d31e9a14861244f1292f61604a296fb7d4e11
Pull Request resolved: #245
@tianyu-l tianyu-l deleted the gh/tianyu-l/9/head branch April 16, 2024 20:03
lessw2020 pushed a commit that referenced this pull request Apr 18, 2024
ghstack-source-id: 287d31e9a14861244f1292f61604a296fb7d4e11
Pull Request resolved: #245
philippguevorguian pushed a commit to YerevaNN/YNNtitan that referenced this pull request Aug 17, 2024
ghstack-source-id: 287d31e9a14861244f1292f61604a296fb7d4e11
Pull Request resolved: pytorch#245
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants