Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply less heavy profiling #270

Merged
merged 2 commits into from
Apr 25, 2024
Merged

apply less heavy profiling #270

merged 2 commits into from
Apr 25, 2024

Conversation

tianyu-l
Copy link
Contributor

@tianyu-l tianyu-l commented Apr 25, 2024

Stack from ghstack (oldest at bottom):

While I try to mitigate #266 by inserting a barrier in the dump step, this PR simplifies profiling to only provide minimal stats, thus making it less heavy.

[ghstack-poisoned]
tianyu-l added a commit that referenced this pull request Apr 25, 2024
ghstack-source-id: d58e921e30f1cede81b5994bf96605093eb88c6f
Pull Request resolved: #270
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Apr 25, 2024
While I try to mitigate #266 by inserting a barrier in the dump step, this PR simplifies profiling to only provide minimal stats, thus making it less heavy.


[ghstack-poisoned]
tianyu-l added a commit that referenced this pull request Apr 25, 2024
ghstack-source-id: 2b74fe48dbeae0367a41214c6d0e8b1fcd608db8
Pull Request resolved: #270
Copy link
Collaborator

@wanchaol wanchaol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tianyu-l tianyu-l merged commit 1c56dd4 into gh/tianyu-l/9/base Apr 25, 2024
4 checks passed
tianyu-l added a commit that referenced this pull request Apr 25, 2024
ghstack-source-id: 2b74fe48dbeae0367a41214c6d0e8b1fcd608db8
Pull Request resolved: #270
@tianyu-l tianyu-l deleted the gh/tianyu-l/9/head branch April 25, 2024 21:43
tianyu-l added a commit to tianyu-l/torchtitan_intern24 that referenced this pull request Aug 16, 2024
ghstack-source-id: 2b74fe48dbeae0367a41214c6d0e8b1fcd608db8
Pull Request resolved: pytorch#270
philippguevorguian pushed a commit to YerevaNN/YNNtitan that referenced this pull request Aug 17, 2024
ghstack-source-id: 2b74fe48dbeae0367a41214c6d0e8b1fcd608db8
Pull Request resolved: pytorch#270
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants