Add more Float8 description #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
tianyu-l
reviewed
Apr 29, 2024
train_configs/debug_model.toml
Outdated
| @@ -37,7 +37,7 @@ steps = 10 | |||
| data_parallel_degree = -1 | |||
| tensor_parallel_degree = 1 | |||
| pipeline_parallel_degree = 1 | |||
| fp8_linear = "" | |||
| fp8_linear = '' # ['', 'dynamic'] See torchtitan/float8_linear.py for more detail | |||
There was a problem hiding this comment.
IMO we should put details about a config into the helper message in config_manager.py. Here we can simply have # ['', 'dynamic'] as the possible options, similar to the norm_type config. But I'm ok with also putting them here.
There was a problem hiding this comment.
yeah that makes sense, I was trying to find the best place for this one I can update this PR
drisspg
force-pushed
the
add-more-fp8-context
branch
from
8504e2c to
5ce52a6
Compare
tianyu-l
pushed a commit
to tianyu-l/torchtitan_intern24
that referenced
this pull request
Aug 16, 2024
# Summary Add more the possible options in the configs and add a note on how to get the dependency at the top of the file.
philippguevorguian
pushed a commit
to YerevaNN/YNNtitan
that referenced
this pull request
Aug 17, 2024
# Summary Add more the possible options in the configs and add a note on how to get the dependency at the top of the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add more the possible options in the configs and add a note on how to get the dependency at the top of the file.