Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cp] fix the device mesh access issue when CP is not used with DP #683

Merged
merged 2 commits into from
Nov 29, 2024
Merged

[cp] fix the device mesh access issue when CP is not used with DP #683

merged 2 commits into from
Nov 29, 2024

Conversation

XilunWu
Copy link
Contributor

@XilunWu XilunWu commented Nov 20, 2024 •
edited
Loading

@XilunWu XilunWu mentioned this pull request Nov 20, 2024
Closed
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 20, 2024
@XilunWu XilunWu changed the title [cp] apply fsdp when only CP is present for correct loss and lower mem usage [cp] fix the device mesh access issue when CP is not used with DP Nov 20, 2024
@XilunWu XilunWu changed the base branch from gh/XilunWu/10/base to main November 20, 2024 00:03
@XilunWu XilunWu mentioned this pull request Nov 20, 2024
Merged
@XilunWu XilunWu requested review from fegin and tianyu-l November 20, 2024 01:06
tianyu-l
tianyu-l approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@tianyu-l tianyu-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@XilunWu XilunWu merged commit 3e3909a into main Nov 29, 2024
5 checks passed
@XilunWu XilunWu mentioned this pull request Dec 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianyu-l tianyu-l tianyu-l approved these changes

@fegin fegin Awaiting requested review from fegin

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XilunWu @tianyu-l @facebook-github-bot