return empty tensor instead of None #332
Conversation
jhcross
force-pushed
the
export-D13969691
branch
from
2b4c4eb to
f7d1697
Compare
Summary: Pull Request resolved: pytorch#332 To allow efficient use of fork/join annotation, we return an empty tensor instead of `None` for `encoder_padding_mask` from transformer encoder in the unmasked/inference case. Note that this slight hack is preferable to more far-reaching changes in, e.g., Fairseq multihead_attention. Differential Revision: D13969691 fbshipit-source-id: 5b6106d8f4ac311ca4a5708898639b18ab2be07d
Differential Revision: D13969501 fbshipit-source-id: 525464bd46f7d5c925e2392ba93f6ef6533dfb63
Summary: Pull Request resolved: pytorch#332 To allow efficient use of fork/join annotation, we return an empty tensor instead of `None` for `encoder_padding_mask` from transformer encoder in the unmasked/inference case. Note that this slight hack is preferable to more far-reaching changes in, e.g., Fairseq multihead_attention. Differential Revision: D13969691 fbshipit-source-id: 862ed44019012449554527f236cb344046c75184
jhcross
force-pushed
the
export-D13969691
branch
from
f7d1697 to
c2fbd68
Compare
|
Hi @jhcross! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Summary:
To allow efficient use of fork/join annotation, we return an empty tensor instead of
Noneforencoder_padding_maskfrom transformer encoder in the unmasked/inference case.Note that this slight hack is preferable to more far-reaching changes in, e.g., Fairseq multihead_attention.
Differential Revision: D13969691