Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tutorial to avoid use of copy.deepcopy()- Convolution/Batch Norm Fuser in FX #2331

Closed
sekyondaMeta opened this issue May 22, 2023 · 4 comments
Closed

Update tutorial to avoid use of copy.deepcopy()- Convolution/Batch Norm Fuser in FX #2331

sekyondaMeta opened this issue May 22, 2023 · 4 comments
Assignees
@MirMustafaAli
Labels
core Tutorials of any level of difficulty related to the core pytorch functionality docathon-h2-2023 easy fx issues related to fx

Comments

@sekyondaMeta
Copy link
Contributor

sekyondaMeta commented May 22, 2023 •
edited by pytorch-bot bot
Loading

Update the Building a convolution/batch norm fuser in FX to avoid the use of copy.deepcopy().
Tutorial link:

tutorials/intermediate_source/fx_conv_bn_fuser.py

Line 107 in 6ae56a1

fused_conv = copy.deepcopy(conv)

See issue #2177 for more information

cc @eellison @suo @gmagogsfm @jamesr66a @msaroufim @SherlockNoMad @albanD @svekars @carljparker @NicolasHug @kit1980 @subramen
@carljparker carljparker mentioned this issue May 26, 2023
Closed
@svekars svekars added easy docathon-h1-2023 A label for the docathon in H1 2023 labels May 31, 2023
@mikebrow
Copy link
Contributor

/assigntome

@JoseLuisC99
Copy link
Contributor

/assigntome

JoseLuisC99 added a commit to JoseLuisC99/tutorials that referenced this issue Jun 6, 2023
@JoseLuisC99
Replaced use of copy.deepcopy(), fix pytorch#2331
f2f1b70
@JoseLuisC99 JoseLuisC99 mentioned this issue Jun 6, 2023
Closed
@svekars
Copy link
Contributor

svekars commented Oct 24, 2023

This issue has been unassigned due to inactivity. If you are still planning to work on this, you can still send a PR referencing this issue.

@svekars svekars added docathon-h2-2023 and removed docathon-h1-2023 A label for the docathon in H1 2023 labels Oct 30, 2023
@MirMustafaAli
Copy link

/assigntome

@MirMustafaAli MirMustafaAli mentioned this issue Nov 4, 2023
Closed
@svekars svekars added core Tutorials of any level of difficulty related to the core pytorch functionality fx issues related to fx labels Nov 6, 2023
@svekars svekars closed this as completed Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MirMustafaAli MirMustafaAli

Labels
core Tutorials of any level of difficulty related to the core pytorch functionality docathon-h2-2023 easy fx issues related to fx
Projects
None yet
Milestone
No milestone
5 participants
@svekars @mikebrow @MirMustafaAli @JoseLuisC99 @sekyondaMeta