-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove fn_kwargs from Filter and Mapper datapipes #5113
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit d0e2acf (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
Job | Step | Action |
---|---|---|
packaging/build_conda.sh | 🔁 rerun |
1 job timed out:
binary_linux_conda_py3.8_cu111
This comment was automatically generated by Dr. CI (expand for details).
Please report bugs/suggestions to the (internal) Dr. CI Users group.
fmassa
approved these changes
Dec 19, 2021
CI failures seem related |
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 21, 2021
Summary: * remove fn_kwargs from Filter and Mapper datapipes * fix leftovers Reviewed By: prabhat00155 Differential Revision: D33253474 fbshipit-source-id: 87ec25e48f87f3fc7d9931ad549139826ad160f4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #5112 (comment). After pytorch/pytorch#69560,
Filter
andMapper
no longer acceptfn_kwargs
.functools.partial
is now the way to go.cc @pmeier @bjuncek