Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove fn_kwargs from Filter and Mapper datapipes #5113

Merged
merged 3 commits into from
Dec 19, 2021

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Dec 19, 2021

Addresses #5112 (comment). After pytorch/pytorch#69560, Filter and Mapper no longer accept fn_kwargs. functools.partial is now the way to go.

cc @pmeier @bjuncek

@facebook-github-bot
Copy link

facebook-github-bot commented Dec 19, 2021

💊 CI failures summary and remediations

As of commit d0e2acf (more details on the Dr. CI page):


  • 2/2 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build binary_win_conda_py3.9_cu115 (1/1)

Step: "Build conda packages" (full log | diagnosis details | 🔁 rerun)

72.131 | ERROR: [NVI2.NVInstaller] 240@CNVIn... {0xe4080000; File: InstallThread.cpp; Line: 112}.
     72.032 |     INFO: [NVI2.NVInstaller] 4198@CNVInstaller::InternalProcessFinalStatus : Calling "C:\Users\circleci\project\packaging\windows\temp_build\cuda\HDAudio\HDAudioExt.dll" to process final status. 
     72.032 |     INFO: [NVI2.NVInstaller] 4203@CNVInstaller::InternalProcessFinalStatus : No processing of finalStatus is carried out, continuing to next extension. 
     72.032 |     INFO: [NVI2.NVInstaller] 4198@CNVInstaller::InternalProcessFinalStatus : Calling "C:\Users\circleci\project\packaging\windows\temp_build\cuda\GFExperience.NvStreamSrv\NvStreamSrvExt.dll" to process final status. 
     72.032 |     INFO: [NVI2.NVInstaller] 4203@CNVInstaller::InternalProcessFinalStatus : No processing of finalStatus is carried out, continuing to next extension. 
     72.032 |     INFO: [NVI2.NVInstaller] 4198@CNVInstaller::InternalProcessFinalStatus : Calling "C:\Users\circleci\project\packaging\windows\temp_build\cuda\ShadowPlay\ShadowPlayExt.DLL" to process final status. 
     72.032 |     INFO: [NVI2.NVInstaller] 4203@CNVInstaller::InternalProcessFinalStatus : No processing of finalStatus is carried out, continuing to next extension. 
     72.032 |    DEBUG: [NVI2.Installation] 107@CInstallationStepper::Present : Presenting "!InstallCheckFailed". 
     72.032 |    DEBUG: [NVI2.Installation] 163@CInstallationStepper::Response : Response - not presenting, auto move next. 
     72.039 |    DEBUG: [NVI2.NVInstaller] 712@CNVInstaller::InternalCleanupCacheDeferred : Scheduling deferred delete using module C:\Users\circleci\AppData\Local\Temp\NVI2_29.DLL waiting for this process C:\Users\circleci\project\packaging\windows\temp_build\cuda\setup.exe 7712. 
     72.131 |    DEBUG: [NVI2.NVInstaller] 761@CNVInstaller::InternalCleanupCacheDeferred : Deferred delete is primed. 
     72.131 |    ERROR: [NVI2.NVInstaller] 240@CNVInstaller::PerformSteps : Installation failed with error Exception {0xe4080000; File: InstallThread.cpp; Line: 112}. 
     72.132 |  WARNING: [NVI2.GFCTelemetryFeedback] 65@CGFCTelemetryFeedback::CGFCTelemetryFeedback : Telemetry reporting disabled. 
     72.132 |  WARNING: [NVI2.GFCTelemetryFeedback] 850@CGFCTelemetryFeedback::SendTelemetry : Telemetry reporting disabled. 
     72.132 |    DEBUG: [NVI2.NVExtension] 201@CNVExtension::InternalUnload : Unloading "C:\Users\circleci\project\packaging\windows\temp_build\cuda\MSVCRT\MSVCRTExt.dll". 
     72.132 |  WARNING: [NVI2.NVExtension] 209@CNVExtension::InternalUnload : Aborted unload of "C:\Users\circleci\project\packaging\windows\temp_build\cuda\MSVCRT\MSVCRTExt.dll" - in use. 
     72.132 |    DEBUG: [NVI2.NVExtension] 201@CNVExtension::InternalUnload : Unloading "C:\Users\circleci\project\packaging\windows\temp_build\cuda\MSVCRT\MSVCRTExt.dll". 
     72.132 |    DEBUG: [NVI2.NVExtension] 205@CNVExtension::InternalUnload : Unloaded "C:\Users\circleci\project\packaging\windows\temp_build\cuda\MSVCRT\MSVCRTExt.dll". 
     72.132 |    DEBUG: [NVI2.NVExtension] 201@CNVExtension::InternalUnload : Unloading "C:\Users\circleci\project\packaging\windows\temp_build\cuda\CUDAToolkit\CUDAToolkitExt.DLL". 
     72.132 |    DEBUG: [NVI2.NVExtension] 205@CNVExtension::InternalUnload : Unloaded "C:\Users\circleci\project\packaging\windows\temp_build\cuda\CUDAToolkit\CUDAToolkitExt.DLL". 
     72.133 |    DEBUG: [NVI2.NVExtension] 201@CNVExtension::InternalUnload : Unloading "C:\Users\circleci\project\packaging\windows\temp_build\cuda\cuda_nvvp\CUDAVisualProfiler\CUDAVisualProfilerExt.dll". 
     72.133 |    DEBUG: [NVI2.NVExtension] 205@CNVExtension::InternalUnload : Unloaded "C:\Users\circleci\project\packaging\windows\temp_build\cuda\cuda_nvvp\CUDAVisualProfiler\CUDAVisualProfilerExt.dll". 

1 failure not recognized by patterns:

Job Step Action
CircleCI binary_linux_conda_py3.8_cu111 packaging/build_conda.sh 🔁 rerun

1 job timed out:

  • binary_linux_conda_py3.8_cu111

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@pmeier pmeier requested review from fmassa and ejguan December 19, 2021 13:17
@fmassa
Copy link
Member

fmassa commented Dec 19, 2021

CI failures seem related

@pmeier pmeier merged commit 1efb567 into pytorch:main Dec 19, 2021
@pmeier pmeier deleted the fix-mapper-filter branch December 19, 2021 13:50
facebook-github-bot pushed a commit that referenced this pull request Dec 21, 2021
Summary:
* remove fn_kwargs from Filter and Mapper datapipes

* fix leftovers

Reviewed By: prabhat00155

Differential Revision: D33253474

fbshipit-source-id: 87ec25e48f87f3fc7d9931ad549139826ad160f4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants