-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable download test for Places365 and SBU #6389
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another failing download is flaky or not tested ? Otherwise, OK for me
Oh yeah, SBU is also failing. I'll have a look. |
Thanks @pmeier How will we remember to revisit this before the next release? |
Given that we are not using GH milestone feature or any other project management tool that I'm aware of, I'll set a notification for myself. If you have a better idea I'm all ears. |
See #6390. Do you want me to disable this in this PR as well or should I send another one? |
@pmeier Is it possible to turn the test into an xfail one so that if it gets fixed we know it? There is no guarantee that this is going to happen before the release (it's beyond our control), but we will make sure not to forget reactivating the test. Trying to thing of ways to unblock this because the specific broken test has been driving us nuts with the warnings for weeks now. |
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pmeier, LGTM
Hey @NicolasHug! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
Summary: * disable download test for Places365 * add xfail test for broken download servers * add more comments * mark SBU download as failing Reviewed By: datumbox Differential Revision: D38824251 fbshipit-source-id: 0244e9377f0e029255eed4ed5c94673d2cfabf5c Co-authored-by: Nicolas Hug <[email protected]>
Adresses #6268. The bot is spamming this once per day. Let's revisit this before the next release to see if we can reinstate the test or disable downloads for Places365 entirely.