Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable download test for Places365 and SBU #6389

Merged
merged 6 commits into from
Aug 15, 2022

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Aug 10, 2022

Adresses #6268. The bot is spamming this once per day. Let's revisit this before the next release to see if we can reinstate the test or disable downloads for Places365 entirely.

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another failing download is flaky or not tested ? Otherwise, OK for me

@pmeier
Copy link
Collaborator Author

pmeier commented Aug 10, 2022

Oh yeah, SBU is also failing. I'll have a look.

@NicolasHug
Copy link
Member

Thanks @pmeier

How will we remember to revisit this before the next release?

@pmeier
Copy link
Collaborator Author

pmeier commented Aug 10, 2022

How will we remember to revisit this before the next release?

Given that we are not using GH milestone feature or any other project management tool that I'm aware of, I'll set a notification for myself. If you have a better idea I'm all ears.

@pmeier
Copy link
Collaborator Author

pmeier commented Aug 10, 2022

Oh yeah, SBU is also failing.

See #6390. Do you want me to disable this in this PR as well or should I send another one?

@datumbox
Copy link
Contributor

@pmeier Is it possible to turn the test into an xfail one so that if it gets fixed we know it? There is no guarantee that this is going to happen before the release (it's beyond our control), but we will make sure not to forget reactivating the test. Trying to thing of ways to unblock this because the specific broken test has been driving us nuts with the warnings for weeks now.

@pmeier pmeier changed the title disable download test for Places365 disable download test for Places365 and SBU Aug 15, 2022
@pmeier
Copy link
Collaborator Author

pmeier commented Aug 15, 2022

Is it possible to turn the test into an xfail one so that if it gets fixed we know it?

Done.

@pmeier pmeier requested a review from datumbox August 15, 2022 01:25
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pmeier, LGTM

@NicolasHug NicolasHug merged commit fa8e34e into pytorch:main Aug 15, 2022
@github-actions
Copy link

Hey @NicolasHug!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request Aug 24, 2022
Summary:
* disable download test for Places365

* add xfail test for broken download servers

* add more comments

* mark SBU download as failing

Reviewed By: datumbox

Differential Revision: D38824251

fbshipit-source-id: 0244e9377f0e029255eed4ed5c94673d2cfabf5c

Co-authored-by: Nicolas Hug <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants