Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to turn off DEBUG mode when building for release #7914

Merged
merged 2 commits into from
Aug 30, 2023

Conversation

atalman
Copy link
Contributor

@atalman atalman commented Aug 30, 2023

Fixes: pytorch/pytorch#97576

According to recommendations in: pypa/cibuildwheel#331

Decreases size from 25mb to 1.1mb for python 3.8 wheel builds

cc @malfet @NicolasHug @pmeier

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 30, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7914

Note: Links to docs will display an error until the docs builds have been completed.

❌ 17 New Failures, 14 Unrelated Failures

As of commit 1194680 with merge base d073a19 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Andrey!

@atalman atalman merged commit 96950a5 into pytorch:main Aug 30, 2023
@github-actions
Copy link

Hey @atalman!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request Sep 6, 2023
Reviewed By: matteobettini

Differential Revision: D48900375

fbshipit-source-id: 5ee6f17c0eed372b27b86f73a16e569be1d733b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

torchvision for Python-3.8 is build with debug symbols
3 participants