Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix drawtext error in html #938

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Conversation

worapolburaphan
Copy link
Contributor

@worapolburaphan worapolburaphan commented Jan 31, 2023

  1. Start QB-Core on a slow or low-spec computer
  2. Access the Debug UI page (localhost:13172)
  3. Encounter an error in the drawtext.js file
  4. The issue stems from the script loading successfully but any resource call function (hideText) and sending an event message before index.html of all resources are fully loaded on NUI it make
 <div className="text" />

Doesn't loaded.

Description

Checklist

  • I have personally loaded this code into an updated qbcore project and checked all of its functionality.
  • My code fits the style guidelines.
  • My PR fits the contribution guidelines.

1. Start QB-Core on a slow or low-spec computer
2. Access the Debug UI page (localhost:13172)
3. Encounter an error in the drawtext.js file
4. The issue stems from the script loading successfully but any resource call function (hideText) and sending an event message before index.html of all resources are fully loaded on NUI it make
`html
<div className="text" />` is not loaded.
@worapolburaphan worapolburaphan changed the title Fix drawtext error Fix drawtext error in html Jan 31, 2023
Copy link
Contributor

@S33G S33G left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@S33G S33G merged commit 14340bb into qbcore-framework:main Jan 31, 2023
S33G pushed a commit that referenced this pull request Feb 10, 2023
@worapolburaphan worapolburaphan deleted the patch-2 branch May 28, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants