WebUI (file)table broken in current master

[xnoreq]

qBittorrent version and Operating System

master (2e5c09a)

If on linux, libtorrent and Qt version

libtorrent 1.1.11
qt 5.12.0
firefox 65

What is the problem

Clicking on the download checkbox of a file in the Content tab in the WebUI does nothing.

Analysis

Please use the firefox web developer inspector to verify this (and also during development to avoid committing such bugs):

The checkbox has a change event:
<input type="checkbox" id="cbPrio0" data-id="0" class="DownloadedCB">

which is embedded in a <tr>.
The <tr> has 2 click and 2 contextmenu events. This already is dubious.

One of the event handlers executes this:

qBittorrent/src/webui/www/private/scripts/dynamicTable.js

Lines 686 to 687 in 2e5c09a

	tr.addEvent('click', function(e) {
	e.stop();

So when I click the checkbox, the tr-click handler stops the event first, so the checkbox changed handler is never called:

qBittorrent/src/webui/www/private/scripts/prop-files.js

Line 57 in 2e5c09a

checkbox.addEvent('change', fileCheckboxChanged);

qBittorrent/src/webui/www/private/scripts/prop-files.js

Line 27 in 2e5c09a

var fileCheckboxChanged = function(e) {

[xnoreq]

One easy way to fix this is to add a click event handler to the input box which calls event.stopPropagation() first (prevents the th click handler from being called).

And the tr click handler already returns false which is equivalent to calling e.preventDefault() which is fine I guess.

edit: it's not just an easy fix, it is more correct than using the change event. The change event on a checkbox has the weird official definition to only fire if the checked stated changed and the checkbox loses focus.

[xnoreq]

xnoreq@ea1a337

[Chocobo1]

Ping @Piccirello.

[Piccirello]

Confirmed this issue was introduced in #10006. Looks like #10153 is also affected.

@xnoreq thanks for reporting this and quickly posting a fix. I've integrated your patch into #10153 since that PR should be merged before the next release.

[Arathen]

It has been a couple of months and this is still broken. Is @Piccirello the only one who can update #10153 so that its suitable for merging? He looks like he's had other commitments on his time lately.