Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display files hierarchically in Web UI content tab #10153

Merged
merged 3 commits into from
Aug 6, 2019
Merged

Display files hierarchically in Web UI content tab #10153

merged 3 commits into from
Aug 6, 2019

Conversation

Piccirello
Copy link
Member

@Piccirello Piccirello commented Jan 13, 2019 •
edited
Loading

Rename functionality is going to take some more time so will be coming in a later PR.

  • Minor API bump to document /api/v2/torrents/files path separator change

Closes #974, closes #4476, closes #10162, closes #10484, closes #10729

Before:
screen shot 2019-01-13 at 4 22 23 am

After:
screen shot 2019-01-13 at 4 20 48 am

@Piccirello Piccirello added the WebUI WebUI-related issues/changes label Jan 13, 2019
@AceLewis AceLewis mentioned this pull request Jan 14, 2019
Open
61 tasks
@Piccirello Piccirello force-pushed the webui-files-table branch 2 times, most recently from 58d706c to bacc131 Compare January 15, 2019 10:57
@Piccirello Piccirello mentioned this pull request Jan 15, 2019
Closed
@Piccirello
Copy link
Member Author

Added @xnoreq's patch for #10162

@Piccirello
Copy link
Member Author

Rebased to fix conflicts

@Piccirello Piccirello mentioned this pull request Jan 20, 2019
Merged
Piccirello
Piccirello commented Jan 20, 2019
View reviewed changes
.gitignore Show resolved Hide resolved
@FranciscoPombal FranciscoPombal mentioned this pull request Mar 20, 2019
Merged
@Piccirello Piccirello added this to the 4.2.0 milestone Apr 16, 2019
@Piccirello Piccirello mentioned this pull request Apr 17, 2019
Closed
@Arathen
Copy link

Arathen commented Jun 17, 2019

Is there an update on this PR by any chance? I would love to see it merged.

Cheers.

@Piccirello
Copy link
Member Author

I’ve been working on a large overhaul of this PR over the last week. It addresses all comments and cleans up the code quite a bit. There’s still a few todos but hoping to have it all pushed within the next few days.

@WolfganP
Copy link

I've recently started to see the Download Priority boxes being grayed out when doing selective downloads and putting the torrent in pause (ie getting just the 1st 2 episodes of a series' season).
In order to recover the functionality of that field and be able to change the priority for individual files, I need to restart the program. I'll make sure I test it again once this PR is merged.

@Piccirello
Copy link
Member Author

@WolfganP have you been experiencing this issue while running off of master, or running off of this branch?

Chocobo1
Chocobo1 reviewed Jun 22, 2019
View reviewed changes
src/webui/www/webui.qrc Outdated Show resolved Hide resolved
glassez
glassez previously approved these changes Jul 14, 2019
View reviewed changes
@Piccirello
Copy link
Member Author

Piccirello commented Jul 14, 2019 •
edited
Loading

I want to manually rebase this before we merge

Edit: whoops, still waiting on #10527. I’ll double check if there’s anything I need to add over there

@jonfortescue
Copy link

@Piccirello looks like this can be rebased now that #10527 has merged through.

@Piccirello
Copy link
Member Author

Rebased onto master

Chocobo1
Chocobo1 reviewed Jul 26, 2019
View reviewed changes
src/webui/www/private/scripts/dynamicTable.js Outdated Show resolved Hide resolved
src/webui/www/private/scripts/dynamicTable.js Outdated Show resolved Hide resolved
src/webui/www/private/scripts/dynamicTable.js Outdated Show resolved Hide resolved
@Piccirello
Copy link
Member Author

Comments addressed

Chocobo1
Chocobo1 reviewed Jul 29, 2019
View reviewed changes
src/webui/www/private/scripts/file-tree.js Outdated Show resolved Hide resolved
src/webui/www/private/scripts/file-tree.js Show resolved Hide resolved
src/webui/www/webui.qrc Outdated Show resolved Hide resolved
@WolfganP WolfganP mentioned this pull request Jul 29, 2019
Closed
@Piccirello
Copy link
Member Author

Comments addressed

Chocobo1
Chocobo1 approved these changes Aug 5, 2019
View reviewed changes
Copy link
Member

@Chocobo1 Chocobo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Chocobo1 Chocobo1 merged commit 733da5f into qbittorrent:master Aug 6, 2019
@Chocobo1
Copy link
Member

Chocobo1 commented Aug 6, 2019

@Piccirello
Thank you!

@Arathen
Copy link

Arathen commented Aug 6, 2019

@Piccirello - thank you so much for your long hard work on this PR! Its a fantastic addition to the WebUI :)

@Piccirello Piccirello deleted the webui-files-table branch August 6, 2019 07:40
@Piccirello
Copy link
Member Author

@Arathen I'm glad this is finally implemented! The original issue is almost 6 years old.

@glassez
Copy link
Member

glassez commented Aug 6, 2019

I'm glad this is finally implemented! The original issue is almost 6 years old.

Maybe you can turn your attention to an equally old issue now?
#453

@Piccirello Piccirello mentioned this pull request Aug 15, 2019
Closed
@bitingsock bitingsock mentioned this pull request Nov 29, 2022
Closed
@foremtehan
Copy link

How can i get list of torrents files before downloading the torrent itself ? Just see the content (metadata) of the torrent?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chocobo1 Chocobo1 Chocobo1 approved these changes

@glassez glassez glassez approved these changes

Assignees
No one assigned
Labels
WebUI WebUI-related issues/changes
Projects
None yet
Milestone
4.2.0
7 participants
@Piccirello @Arathen @WolfganP @glassez @jonfortescue @Chocobo1 @foremtehan