Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match WebUI About page to GUI #10096

Merged
merged 2 commits into from
Jan 31, 2019
Merged

Match WebUI About page to GUI #10096

merged 2 commits into from
Jan 31, 2019

Conversation

Piccirello
Copy link
Member

@Piccirello Piccirello commented Jan 2, 2019 •
edited
Loading

Closes #10069

@WolfganP
Copy link

WolfganP commented Jan 2, 2019

@Piccirello for those of us building from github's master, is it possible to add to the About page any indication of what was the latest PR/commit at the head to make sure which changes the build includes? (I think it will help in the issues' discussions to make sure at runtime that certain features were applied and the testing contribution is accurate).
As always, thanks for your WebUI work!

@sledgehammer999 sledgehammer999 added the WebUI WebUI-related issues/changes label Jan 3, 2019
@Piccirello
Copy link
Member Author

@WolfganP I like the idea. My time to work on qBittorrent is unfortunately shorter than ever though, so I'm trying to exclusively focus on web features.

@Piccirello Piccirello force-pushed the webui-libtorrent-version branch from aaeda85 to 3d3f359 Compare January 10, 2019 10:21
@Piccirello
Copy link
Member Author

Piccirello commented Jan 10, 2019 •
edited
Loading

I've greatly expanded the scope of this PR which probably warrants opening a new one, but I'll just continue here.

Rather than just adding the libtorrent version, I've matched the info in the Web UI's about page to the GUI.

Screenshots:

screen shot 2019-01-10 at 2 29 49 am

screen shot 2019-01-10 at 2 29 55 am

screen shot 2019-01-10 at 2 30 00 am

screen shot 2019-01-10 at 2 30 00 am

screen shot 2019-01-10 at 2 30 06 am

screen shot 2019-01-10 at 2 30 11 am

screen shot 2019-01-10 at 2 30 17 am

@Piccirello Piccirello changed the title Add Libtorrent version to WebUI about page Match WebUI About page to GUI Jan 10, 2019
@AceLewis AceLewis mentioned this pull request Jan 10, 2019
Open
61 tasks
@Piccirello Piccirello force-pushed the webui-libtorrent-version branch from 3d3f359 to ecd3835 Compare January 10, 2019 10:29
@Piccirello Piccirello force-pushed the webui-libtorrent-version branch from ecd3835 to 21d488b Compare January 10, 2019 20:43
@Piccirello
Copy link
Member Author

Piccirello commented Jan 10, 2019 •
edited
Loading

Dropping a note here since it may be of interest to some people in this thread- I'm very close to opening a PR adding directory support to the Web UI's content tab. I'm just putting the finishing touches on the rename file/folder API, and then it'll be ready. I know this has been a really big pain point for a lot of people, myself included.

@Piccirello Piccirello force-pushed the webui-libtorrent-version branch 3 times, most recently from ade7c59 to e519227 Compare January 13, 2019 23:25
@Piccirello Piccirello force-pushed the webui-libtorrent-version branch from e519227 to 1c819c1 Compare January 14, 2019 05:55
@Piccirello Piccirello force-pushed the webui-libtorrent-version branch from 1c819c1 to 2a655ed Compare January 20, 2019 21:44
@Piccirello Piccirello force-pushed the webui-libtorrent-version branch from 2a655ed to 37315f1 Compare January 21, 2019 02:36
@Piccirello Piccirello force-pushed the webui-libtorrent-version branch from 37315f1 to d1dc9a3 Compare January 21, 2019 02:40
glassez
glassez reviewed Jan 24, 2019
View reviewed changes
src/webui/api/appcontroller.cpp
{"qt", QT_VERSION_STR},
{"libtorrent", Utils::Misc::libtorrentVersionString()},
{"boost", Utils::Misc::boostVersionString()},
{"openssl", Utils::Misc::opensslVersionString()},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, why don't we mention one more direct dependency library, ZLib?
(GUI too)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created issue #10240

@Chocobo1 Chocobo1 merged commit 899b0c1 into qbittorrent:master Jan 31, 2019
@Chocobo1
Copy link
Member

Thank you!

@Piccirello Piccirello deleted the webui-libtorrent-version branch January 31, 2019 23:16
@Piccirello Piccirello mentioned this pull request Jun 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glassez glassez glassez approved these changes

@Chocobo1 Chocobo1 Chocobo1 approved these changes

Assignees
No one assigned
Labels
WebUI WebUI-related issues/changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Piccirello @WolfganP @Chocobo1 @glassez @sledgehammer999