Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose contentPath in WebAPI torrents/info #13625

Merged
merged 1 commit into from
Oct 25, 2020

Conversation

FranciscoPombal
Copy link
Member

Bump WebAPI version to 2.6.1

Bump WebAPI version to 2.6.1
@FranciscoPombal FranciscoPombal added the WebAPI WebAPI-related issues/changes label Oct 23, 2020
@FranciscoPombal
Copy link
Member Author

@glassez

Question:

The differences between the TorrentHandle::*path family of functions is explained here:

// 1. savePath() - the path where all the files and subfolders of torrent are stored (as always).
.
However, the meaning of the actual parameter is unclear to me. What does it do exactly, and should it be used in the WebAPI?

@thalieht
Copy link
Contributor

However, the meaning of the actual parameter is unclear to me.

Looking at TorrentHandleImpl::savePath actual refers to the save path given by libtorrent whereas not actual is adjusted with category and i don't know what else, so keep it false.

@glassez
Copy link
Member

glassez commented Oct 24, 2020

What does it do exactly

It is used to obtain actual location of files when temp folder is used.

should it be used in the WebAPI?

I think no.
It has not been used until now, and there were no problems here.
In addition, the requested attribute is supposed to be used for completed torrents.
And more. The rework of the save subsystem discussed earlier is at the top of my to-do list (after fixing current issues), and there will no longer be any temporary folder operating behind the scenes.

@FranciscoPombal FranciscoPombal added this to the 4.3.1 milestone Oct 24, 2020
@glassez glassez merged commit 0a2a71e into qbittorrent:master Oct 25, 2020
@glassez
Copy link
Member

glassez commented Oct 25, 2020

Thank you!

@FranciscoPombal FranciscoPombal deleted the expose_content_path branch October 25, 2020 10:20
IceCodeNew pushed a commit to IceCodeNew/qBittorrent-Enhanced-Edition that referenced this pull request Oct 28, 2020
…ent_path

Expose contentPath in WebAPI torrents/info
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebAPI WebAPI-related issues/changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants