Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump WebAPI version #14275

Merged
merged 1 commit into from
Jan 24, 2021
Merged

Bump WebAPI version #14275

merged 1 commit into from
Jan 24, 2021

Conversation

glassez
Copy link
Member

@glassez glassez commented Jan 23, 2021

#13995 was supposed to be included in the release along with other API changes, so both PRs had a version change to 2.7.0. However, it ended up in another release, and I forgot to upgrade the version again.

Unfortunately, it is unlikely to fix a problem like #14266, but at least it will fix it for users of intermediate/test builds.
@qbittorrent/bug-handlers, what do you think?

@glassez glassez added Hotfix Fix some bug(s) introduced by recently merged commit(s) WebAPI WebAPI-related issues/changes labels Jan 23, 2021
@glassez glassez added this to the 4.3.4 milestone Jan 23, 2021
@glassez glassez requested a review from Chocobo1 January 23, 2021 11:06
@glassez glassez removed this from the 4.3.4 milestone Jan 23, 2021
@masterwishx
Copy link

OK :-) , so we need to wait next version 4.3.4 ?
for rename folder in WEBUI #13995 ?

@glassez
Copy link
Member Author

glassez commented Jan 24, 2021

OK :-) , so we need to wait next version 4.3.4 ?
for rename folder in WEBUI #13995 ?

"rename folder in WEBUI" is in v4.3.3.
The problem is that I forgot to increase the web API version number. This affects third-party web clients.

@masterwishx
Copy link

OK :-) , so we need to wait next version 4.3.4 ?
for rename folder in WEBUI #13995 ?

"rename folder in WEBUI" is in v4.3.3.
The problem is that I forgot to increase the web API version number. This affects third-party web clients.

so its cant be used even its avalible in code of 4.3.3 and we need to wait next release 4.3.4 with fixed web API , thats what i meaned, right?

@glassez
Copy link
Member Author

glassez commented Jan 24, 2021

so its cant be used even its avalible in code of 4.3.3 and we need to wait next release 4.3.4 with fixed web API , thats what i meaned, right?

No.
You can use it. But you can't tell if it's available based on the API version alone. The following situation is obtained:

  1. qBittorrent v4.3.2 provides API v2.7 that has no such feature
  2. qBittorrent v4.3.3 has this feature but API version is still 2.7 (still my apologies)

@glassez glassez merged commit 50c0092 into qbittorrent:master Jan 24, 2021
@glassez glassez deleted the webapi-version branch January 24, 2021 09:23
@masterwishx
Copy link

i didnt finded this option - rename folder (right mouse click) in binhex/arch-qbittorrentvpn based on 4.3.3 after updated from 4.3.2 docker yestuday.
Now i tried and SURPRISE -> this option avalible on the same Docker version that i tried yestuday... how it can be possible ?!?
Any way Thanks a lot for your hard and Amazing for work.
im glad that switched from uTorrent to qBittorrent Docker...

@glassez
Copy link
Member Author

glassez commented Jan 24, 2021

how it can be possible ?!?

Probably due to cached js scripts.

@masterwishx
Copy link

Ah OK,Thanks again

IceCodeNew pushed a commit to IceCodeNew/qBittorrent-Enhanced-Edition that referenced this pull request Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hotfix Fix some bug(s) introduced by recently merged commit(s) WebAPI WebAPI-related issues/changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants