Improve self-documentation of 3llo by adding a --help switch, show errors without confusing tracebacks
#39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw the build failure appears to be unrelated: when running |
worldofpeace
suggested changes
Jul 29, 2019
qcam
requested changes
Jul 29, 2019
|
@Ma27 Thank you for the PR, I left a few comments then I think we're good to go. |
|
THanks a lot for all the feedback! I'll do my best to fix that during one of the next days :) |
…errors without confusing tracebacks
Ma27
force-pushed
the
help-switch-and-colorized-warnings
branch
from
855ffd1 to
7667c67
Compare
|
@qcam @worldofpeace thanks for the review! Sorry for the delay, I addressed your comments, would you mind having another look? :) |
qcam
approved these changes
Aug 25, 2019
|
Thanks @Ma27 ❤️! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a
--helpswitch which prints the help text in an unindented version to make the program self-documenting. Also added abegin->rescueblock around the environment validation to avoid printing confusing tracebacks with errors when invoking the program without any arguments the first time.