Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where does data package export file go? #1033

Closed
kayakr opened this issue Jul 21, 2020 · 1 comment
Closed

Where does data package export file go? #1033

kayakr opened this issue Jul 21, 2020 · 1 comment
Labels
est:Minor Minor effort to implement problem:Bug A bug

Comments

@kayakr
Copy link

kayakr commented Jul 21, 2020

I imported a TSV, added some column, table and provenance info, validated ok. If I click "Export" icon, I see message "Export package success" and "Data package exported." but there's no indication of the file name or file path, and I can't find any resulting file on my system.

Desired Behaviour (for feature requests only)

Export of data package or data properties reports success as well as file path and file name saved.

Current Behaviour (for problems)

Application claims success of export but provides no indication as to where exported file is, or how exported file is named.

Your Environment

Data Curator 1.2.3-beta on MacOS 10.13.6

@ghost
Copy link

ghost commented Jul 21, 2020

Hi @kayakr
It looks like the underlying frictionless library doesn't support anything other than CSV file for export. We had upgraded the library and this wasn't enforced in earlier versions.
The error wasn't being sent up the stack so we can at least make sure this is done so the user has feedback that the export did not succeed.
I'm not sure what to do about Table Schema not allowing non-csv files. I'll have to look at whether we can still ignore this error to allow saving non-csv files, without breaking some other part of the frictionless functionality which we might rely on.

@ghost ghost added est:Minor Minor effort to implement problem:Bug A bug labels Jul 24, 2020
@ghost ghost closed this as completed in 14bcc26 Jul 24, 2020
ghost pushed a commit that referenced this issue Jul 24, 2020
…ess library) is ignored to allow successful export of TSV formatted packages.
@ghost ghost added this to the Bug fixes in support release 1.2.5 milestone Oct 8, 2020
ghost pushed a commit that referenced this issue Apr 21, 2021
…ommunicated to the user with at least a hint of the issue from frictionless error message.
ghost pushed a commit that referenced this issue Apr 21, 2021
…ess library) is ignored to allow successful export of TSV formatted packages.
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
est:Minor Minor effort to implement problem:Bug A bug
Projects
None yet
Development

No branches or pull requests

1 participant