Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Universal class for all type of embedding models #86

Closed
generall opened this issue Jan 6, 2024 · 1 comment
Closed

Universal class for all type of embedding models #86

generall opened this issue Jan 6, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@generall
Copy link
Member

generall commented Jan 6, 2024

It looks like currently we have different base classes for Jina and all the other embedding models.
That creates confusing user experience and in general over-complicates usage (see tests, for example).

We need to implement a single common class for all dense text models, which should internally route to the proper internal implementaiton.

@generall generall added the enhancement New feature or request label Jan 6, 2024
@joein
Copy link
Member

joein commented Jan 7, 2024

+1

We already have problem with using JinaEmbedding within qdrant-client integration, there is just no interface to choose it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants