feat: HuggingFace download support for FlagEmbedding #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anush008
force-pushed
the
hf-flagembedding-download
branch
from
193dcc1 to
3f28f78
Compare
Anush008
force-pushed
the
hf-flagembedding-download
branch
from
3f28f78 to
33a5901
Compare
NirantK
suggested changes
Jan 16, 2024
Anush008
force-pushed
the
hf-flagembedding-download
branch
2 times, most recently
from
b022c9f to
a3f86a8
Compare
Anush008
force-pushed
the
hf-flagembedding-download
branch
from
a3f86a8 to
1371984
Compare
|
@NirantK, review please. |
Anush008
force-pushed
the
hf-flagembedding-download
branch
2 times, most recently
from
c8890e8 to
7a64189
Compare
Anush008
force-pushed
the
hf-flagembedding-download
branch
from
7a64189 to
ce72a74
Compare
NirantK
suggested changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Promote Huggingface Hub to first class citizen #81 by adding support for downloading
FlagEmbeddingmodels from HuggingFace with fallback to GCS for backward compatibility.Fixes interruption of model downloading leads to a corrupted cache #88 as downloads from HuggingFace are resumed from the point of interruption.
This change also works up towards #86, since now
JinaEmbeddingdiffers only by an extra mean pooling step.