-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix paraphrase minilm #436
base: main
Are you sure you want to change the base?
Conversation
We need to add a warning that the model has been updated, something similar to the one we're showing when users use splade with incorrect spelling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please upload notebooks to reproduce canonical vectors to the dedicated repo?
@@ -12,7 +12,6 @@ keywords = ["vector", "embedding", "neural", "search", "qdrant", "sentence-trans | |||
|
|||
[tool.poetry.dependencies] | |||
python = ">=3.9.0" | |||
onnx = ">=1.15.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should not be in this PR
@@ -62,6 +63,14 @@ def __init__( | |||
**kwargs, | |||
): | |||
super().__init__(model_name, cache_dir, threads, **kwargs) | |||
if model_name == "sentence-transformers/paraphrase-multilingual-MiniLM-L12-v2": | |||
warnings.warn( | |||
"The model 'sentence-transformers/paraphrase-multilingual-MiniLM-L12-v2' has been updated to include a mean pooling layer. " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please add fastembed version in which it's gonna changed? (0.5.2)
All Submissions:
ref: #368
New Feature Submissions:
pre-commit
withpip3 install pre-commit
and set up hooks withpre-commit install
?New models submission: