-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Expose Setting for GRPC Channel-Level Compression at Client Side #480
Conversation
✅ Deploy Preview for poetic-froyo-8baba7 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi @geetu040 Thanks for the contribution! Do you think it would be possible to add some tests? |
@joein Thanks for seeing, I have added some test cases |
This PR Closes #87 |
Hi @joein |
Hey Thanks for the contribution and sorry for the late response Actually we would not like to extend client's signature with this parameter, since the signature is already large. |
Hey @joein |
…sion in qdrant/grpc/__init__.py
eh, found a discrepancy between pre-commit setup and async-client-generator, should be fixed by now |
@geetu040 thanks for the contribution! |
#480) * expose grpc channel-level compression settings in base functions * expose grpc channel-level compression settings in remote classes * expose grpc channel-level compression settings in client * raise TypeError for compression * added test cases for grcp channel-level compression * move grpc_compression parameter from client's signature to **kwargs * use grpc.Compression instead of creating new enum qdrant.grpc.Compression in qdrant/grpc/__init__.py * refactor grpc_compression type hint * fix: Compression instead of grpc.Compression in type hint * tests: move and update tests * chore: remove magic method * fix: fix async client generator, update precommit dependencies * fix: update isort options * fix: update dev dependencies --------- Co-authored-by: George Panchuk <[email protected]>
All Submissions:
dev
branch. Did you create your branch fromdev
?New Feature Submissions:
pre-commit
withpip3 install pre-commit
and set up hooks withpre-commit install
?Changes to Core Features:
Issue
This PR refers to this issue #87 . It enables client to set GZip, grpc compression algorithm. By default no algorithm is applied.
Following code was modified
Usage
Gzip compression algorithm
No compression algorithm