-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow usage of environment variables in rules path #608
Draft
nicogodet
wants to merge
3
commits into
qgis-deployment:main
Choose a base branch
from
nicogodet:env-var-context
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,6 +14,7 @@ | |
# Standard library | ||
import json | ||
import logging | ||
import os | ||
import platform | ||
from datetime import date | ||
from getpass import getuser | ||
|
@@ -43,6 +44,13 @@ | |
|
||
|
||
class QdtRulesContext: | ||
def __init__( | ||
self, | ||
only_prefixed_variables: bool = True, | ||
variables_prefix: list[str] = ["QDT_", "QGIS_"], | ||
) -> None: | ||
self.only_prefixed_variables = only_prefixed_variables | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Docstring is missing |
||
self.variables_prefix = variables_prefix | ||
|
||
@property | ||
def _context_date(self) -> dict: | ||
|
@@ -60,6 +68,29 @@ def _context_date(self) -> dict: | |
"current_year": today.year, | ||
} | ||
|
||
@property | ||
def _context_env(self) -> dict: | ||
"""Returns a dictionary containing environment variables that can be used in | ||
QDT various places: rules... | ||
|
||
The environment variables can be filtered based on self.only_prefixed_variables | ||
and self.variables_prefix settings. | ||
|
||
Returns: | ||
dict: dict with environment variables to use in rules. | ||
""" | ||
env_vars = dict(os.environ) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's already a mapping object no? |
||
|
||
if self.only_prefixed_variables: | ||
# Filter variables that start with any of the prefixes | ||
return { | ||
key: value | ||
for key, value in env_vars.items() | ||
if any(key.startswith(prefix) for prefix in self.variables_prefix) | ||
} | ||
|
||
return env_vars | ||
|
||
@property | ||
def _context_environment(self) -> dict: | ||
"""Returns a dictionary containing some environment information (computer, network, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer complete function import rather than package. See other projects modules where we work with env vars to make it consistent with.