Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix move selected to top #31966

Merged
merged 2 commits into from
Oct 30, 2019
Merged

Fix move selected to top #31966

merged 2 commits into from
Oct 30, 2019

Conversation

m-kuhn
Copy link
Member

@m-kuhn m-kuhn commented Sep 23, 2019

Fix #28914

@troopa81 this is a partial revert of #8725 .
According to the description of #8725 this was not part of the fix, but I'm not entirely sure. Do you remember why you changed these lines?

@nyalldawson
Copy link
Collaborator

Could you add a test for this? This feature breaks all the time...

@troopa81
Copy link
Contributor

@m-kuhn I don't remember exactly why I did this, it was not indeed the main part of the fix. I think it was to avoid calling sort when it doesn't need to (but I understand it needs to for some reason).

@stale
Copy link

stale bot commented Oct 8, 2019

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@stale stale bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Oct 8, 2019
@nyalldawson nyalldawson added the Frozen Feature freeze - Do not merge! label Oct 13, 2019
@stale stale bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Oct 13, 2019
@nyalldawson nyalldawson added backport release-3_10 Bug Either a bug report, or a bug fix. Let's hope for the latter! Requires Tests! Waiting on the submitter to add unit tests before eligible for merging and removed Frozen Feature freeze - Do not merge! labels Oct 25, 2019
@nyalldawson nyalldawson added this to the 3.12.0 milestone Oct 27, 2019
@m-kuhn m-kuhn removed the Requires Tests! Waiting on the submitter to add unit tests before eligible for merging label Oct 30, 2019
@m-kuhn m-kuhn merged commit 6746fec into qgis:master Oct 30, 2019
@m-kuhn m-kuhn deleted the fix28914 branch October 30, 2019 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move selection to top doesn't worked when table is unsaved
3 participants