add enabled state for annotation items #55798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(this doesn't seem to work as expected, items are still rendered) |
|
@3nids is this planned to be API only? I'm unsure how we'd expose a way to re-enable items after they've been disabled in the gui... |
|
Yes, it's API only. |
|
Sorry, my bad, this is working as expected and ready to be merged. |
|
|
what would you expect as a test, a blank image check? |
|
Maybe rendering a layer containing a mix of enabled/disabled annotations |
nyalldawson
reviewed
Jan 12, 2024
3nids
force-pushed
the
annotation-item-enabled
branch
from
7dc9e36 to
4ab050e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
3nids
force-pushed
the
annotation-item-enabled
branch
from
4ab050e to
269b24b
Compare
3nids
added
the
Squash!
|
ok, now with a basic test |
nyalldawson
approved these changes
Jan 16, 2024
|
Approved -- but I think that mask image is out of date and should be removed? It seems to be no resemblance to the rendered image |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to be able to control visibility per items in an annotation layer.