[Georeferencer] Fix setting target CRS (Fix #59902) #59903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agiudiceandrea
added
Georeferencer
backport queued_ltr_backports
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
agiudiceandrea
added
the
Bug
agiudiceandrea
changed the title
agiudiceandrea
added
backport release-3_34
and removed
backport queued_ltr_backports
|
I believe that the mix of categories was kept for backward compatiblity support. Any cleanup is welcome :) |
3nids
approved these changes
Jan 6, 2025
This was referenced Jan 6, 2025
JanCaha
pushed a commit
to JanCaha/QGIS
that referenced
this pull request
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an oversight in #47279 where the target CRS set in the Georeferencer's "Transformation Settings" dialog window was not actually saved in the "QGIS3.ini" settings file.
I've remapped the setting from
targetsrsin the[Plugin-GeoReferencer]section togeoreferencer\last-target-crsin the[app]section for consistency with other settings in the same dialog window. This shouldn't create a backward incompatibility since the previous settings was never actually written in the "QGIS3.ini" settings file.The setting is stored as a
QgsCoordinateReferenceSystem::authid()string.Fixes #59902.
Side note: the Georeferencer stores it's settings in both the
[Plugin-GeoReferencer]section and the[app]section. @3nids, is that intended?