-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Virtual point clouds overview in 3D #60106
Conversation
Unit tests are on their way ✌️ |
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
This commit contains some changes created during rebasing onto current master, however they are insifignant and should be ignored, as they will match the changes already in master.
This bug occurs when some of the referenced point cloud files are missing.
Bug occurs when the vpc data is not complete and 3D renderer gets recreated
cac4d3b
to
61b1406
Compare
Tests failed for Qt 5One or more tests failed using the build from commit 61b1406 classified_render_overviewclassified_render_overviewTest failed at testOverviewRender at tests/src/python/test_qgspointcloudclassifiedrenderer.py:497 Rendered image did not match tests/testdata/control_images/pointcloudrenderer/expected_classified_render_overview/expected_classified_render_overview.png (found 4548 pixels different) The full test report (included comparison of rendered vs expected images) can be found here. Further documentation on the QGIS test infrastructure can be found in the Developer's Guide. |
Tests failed for Qt 6One or more tests failed using the build from commit 61b1406 virtual_pointcloud_3d_extents (testPointCloud3DExtents)virtual_pointcloud_3d_extentsTest failed at testPointCloud3DExtents at tests/src/3d/testqgspointcloud3drendering.cpp:562
classified_render_overviewclassified_render_overviewTest failed at testOverviewRender at tests/src/python/test_qgspointcloudclassifiedrenderer.py:497 Rendered image did not match tests/testdata/control_images/pointcloudrenderer/expected_classified_render_overview/expected_classified_render_overview.png (found 4548 pixels different) The full test report (included comparison of rendered vs expected images) can be found here. Further documentation on the QGIS test infrastructure can be found in the Developer's Guide. |
61b1406
to
5cf8d37
Compare
5cf8d37
to
72f6178
Compare
Description
This PR builds on top of work done in #59854 and extends this functionality to 3D view.
We switch from rendering extents when zoomed out to rendering overview when it's present. This change adds seamless transition between overview into specific point clouds. Furthermore the user is able to switch between just extents, just overview and extents rendered over overview, by using combo box in layer styling side panel under 3D symbol settings.
Screencast_20250110_114513.mp4
Also there was some work done to fix bugs which crashed/froze QGIS, when working with partial VPCs.
Funded by: Klimadatastyrelsen