Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processing] Guard QGIS from crashing due to erroneous extent / invalid CRS in XYZ creation algorithms #60199

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

nirvn
Copy link
Contributor

@nirvn nirvn commented Jan 21, 2025

Description

Related to #60069 , this PR prevents QGIS from crashing when transforming erroneous bounding boxes within our pair of XYZ creation algorithms.

One thing I was wondering here is whether we should warn people if the WGS84 bounding box of their extent parameter results is a bounding box that goes beyond WGS84's limits. @nyalldawson , @m-kuhn , @alexbruy , thoughts?

@nirvn nirvn added the Processing Relating to QGIS Processing framework or individual Processing algorithms label Jan 21, 2025
@github-actions github-actions bot added this to the 3.42.0 milestone Jan 21, 2025
@m-kuhn
Copy link
Member

m-kuhn commented Jan 21, 2025

The fix is absolutely worth it

One thing I was wondering here is whether we should warn people if the WGS84 bounding box of their extent parameter results is a bounding box that goes beyond WGS84's limits. @nyalldawson , @m-kuhn , @alexbruy , thoughts?

Not sure in what scenario that would actually help someone

@alexbruy
Copy link
Contributor

One thing I was wondering here is whether we should warn people if the WGS84 bounding box of their extent parameter results is a bounding box that goes beyond WGS84's limits.

I don't have a strong opinion here. I think that if someone selects incorrect extent/CRS such message won't be very helpful anyway.

Copy link

github-actions bot commented Jan 21, 2025

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit 202ff1f)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit 202ff1f)

@agiudiceandrea
Copy link
Member

QGIS LTR 3.34 is EOL and the upcoming QGS 3.40.4 will be the new QGIS LTR, so I think the tag "backport queued_ltr_backports" is not needed at the moment.

@m-kuhn
Copy link
Member

m-kuhn commented Jan 22, 2025

I'll merge this, a fixed crasher in the last ever 3.34 release is a good thing

@agiudiceandrea
Copy link
Member

agiudiceandrea commented Jan 22, 2025

@m-kuhn the last point release of QGIS 3.34 has been already released and no other point release of QGIS 3.34 is planned to be released according to the roadmap.

@m-kuhn
Copy link
Member

m-kuhn commented Jan 22, 2025

Oh... Right ... Time to update to 3.40 then 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-3_40 Processing Relating to QGIS Processing framework or individual Processing algorithms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants