-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[processing] Guard QGIS from crashing due to erroneous extent / invalid CRS in XYZ creation algorithms #60199
Conversation
…id CRS in XYZ creation algorithms
The fix is absolutely worth it
Not sure in what scenario that would actually help someone |
I don't have a strong opinion here. I think that if someone selects incorrect extent/CRS such message won't be very helpful anyway. |
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
QGIS LTR 3.34 is EOL and the upcoming QGS 3.40.4 will be the new QGIS LTR, so I think the tag "backport queued_ltr_backports" is not needed at the moment. |
I'll merge this, a fixed crasher in the last ever 3.34 release is a good thing |
@m-kuhn the last point release of QGIS 3.34 has been already released and no other point release of QGIS 3.34 is planned to be released according to the roadmap. |
Oh... Right ... Time to update to 3.40 then 🙃 |
Description
Related to #60069 , this PR prevents QGIS from crashing when transforming erroneous bounding boxes within our pair of XYZ creation algorithms.
One thing I was wondering here is whether we should warn people if the WGS84 bounding box of their extent parameter results is a bounding box that goes beyond WGS84's limits. @nyalldawson , @m-kuhn , @alexbruy , thoughts?