Always fallback to default coordinate operations when bounding box transfrom fails #60759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyalldawson
added
Regression
…ansfrom fails Bounding box transforms are inherently approximate, so we can safely just fallback to the proj default operation if the user-specified operation fails when transforming a bounding box. This fixes cases where the user-specified operation involves a grid shift and the bounds to transform falls outside of the grid. In this case proj_trans_bounds fails. By falling back to a proj default operation and re-trying then we get a valid approximate transformation of the bounding box. Fixes map rendering issues when users are using a grid shift operation to transform layers to map CRS Fixes qgis#60737 Fixes qgis#60753
nyalldawson
force-pushed
the
fix_60737
branch
from
9925e29 to
5a330ed
Compare
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
lbartoletti
reviewed
Feb 26, 2025
| @@ -127,6 +127,51 @@ def testTransformQgsRectangle_Regression17600(self): | |||
| myTransformedExtentReverse.yMinimum(), myExtent.yMinimum() | |||
| ) | |||
|
|
|||
| def test_transform_bounding_box_grid(self): | |||
| """ | |||
| This test assumes the ca_nrc_NA83SCRS.tif grid is available on the system! | |||
There was a problem hiding this comment.
So, can you skip the test if ca_nrc_NA83SCRS.tif is not available?
There was a problem hiding this comment.
I don't know any way to determine that reliably. (The test will just silently pass if the grid isn't available, as the default operation will always be used).
At least on the Qt 6 Fedora builds the grids are installed, I'm not sure about the Qt5 CI runs
alexbruy
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bounding box transforms are inherently approximate, so we can safely just fallback to the proj default operation if the user-specified operation fails when transforming a bounding box.
This fixes cases where the user-specified operation involves a grid shift and the bounds to transform falls outside of the grid. In this case proj_trans_bounds fails. By falling back to a proj default operation and re-trying then we get a valid approximate transformation of the bounding box.
Fixes map rendering issues when users are using a grid shift operation to transform layers to map CRS
Fixes #60737
Fixes #60753