Skip to content

Commit

Permalink
Merge pull request #236 from talentlessguy/remove-abort-controller
Browse files Browse the repository at this point in the history
Remove redundant AbortController polyfill
  • Loading branch information
qgustavor authored Feb 7, 2025
2 parents cf94ba2 + 39f43cb commit 8af67f9
Show file tree
Hide file tree
Showing 8 changed files with 5 additions and 12 deletions.
2 changes: 0 additions & 2 deletions build.js
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ async function doBundle (format) {
external: format.bundleExternals
? []
: [
'abort-controller',
'agentkeepalive',
'multistream',
'node-fetch',
Expand All @@ -89,7 +88,6 @@ async function doBundle (format) {
: [alias({
http: require.resolve('./browser/noop.mjs'),
https: require.resolve('./browser/noop.mjs'),
'abort-controller': require.resolve('./browser/noop.mjs'),
'node-fetch': require.resolve('./browser/fetch.mjs'),
'./crypto/rsa.mjs': require.resolve('./browser/rsa.mjs'),
'./aes.mjs': require.resolve('./browser/aes.mjs'),
Expand Down
3 changes: 0 additions & 3 deletions lib/abort-controller-polyfill.mjs

This file was deleted.

1 change: 0 additions & 1 deletion lib/api.mjs
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { EventEmitter } from 'events'
import { Agent as HttpAgent } from 'http'
import { Agent as HttpsAgent } from 'https'
import AbortController from './abort-controller-polyfill.mjs'
import { createPromise } from './util.mjs'

const MAX_RETRIES = 4
Expand Down
1 change: 0 additions & 1 deletion lib/file.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import { EventEmitter } from 'events'
import { streamToCb, createPromise } from './util.mjs'
import { PassThrough } from 'stream'
import StreamSkip from 'stream-skip'
import AbortController from './abort-controller-polyfill.mjs'

class File extends EventEmitter {
constructor (opt) {
Expand Down
7 changes: 5 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@
"provenance": true
},
"dependencies": {
"abort-controller": "^3.0.0",
"pumpify": "^2.0.1",
"stream-skip": "^1.0.3"
},
Expand Down
1 change: 0 additions & 1 deletion test/helpers/test-runner.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@ if (testedPlatform === 'node') {
// The below aliases are copied from build.js
http: require.resolve('../../browser/noop.mjs'),
https: require.resolve('../../browser/noop.mjs'),
'abort-controller': require.resolve('../../browser/noop.mjs'),
'node-fetch': require.resolve('../../browser/fetch.mjs'),
'./crypto/rsa.mjs': require.resolve('../../browser/rsa.mjs'),
'./aes.mjs': require.resolve('../../browser/aes.mjs'),
Expand Down
1 change: 0 additions & 1 deletion types/cjs.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import { EventEmitter } from 'events'
import { Agent as HttpAgent } from 'http'
import { Agent as HttpsAgent } from 'https'

import AbortController from 'abort-controller'
import type * as fetch from 'node-fetch'

declare function megajs (options: megajs.StorageOpts, cb?: megajs.errorCb): megajs.Storage
Expand Down

0 comments on commit 8af67f9

Please sign in to comment.