Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fx: remove delete password function to send more file at once #76

Closed
wants to merge 4 commits into from

Conversation

bim-g
Copy link

@bim-g bim-g commented Nov 17, 2020

fx: remove delete password function to send more file at once

@qgustavor
Copy link
Owner

Pull request rejected because:

  • It changes more that what the pull request describes;
  • On previous pull requests and in Rewrite library and release new major version #64 I said I'm against placing examples in readme and in the repository;
  • Code style, again, is not being followed;
  • I'm against placing dist files in the repository too, those are hosted in NPM;
  • Commiting commented code is bad: we use git, if some code needs to be restored just use the history;
  • You don't need to store the password to send multiple files at once, just run the upload functions in parallel (although I don't recommend that based on my experience); if you need to reuse the storage instance between processes use JSON serialisation functions (which needs to be documented, see Allow Storage saving and loading #12).

@qgustavor qgustavor closed this Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants