Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming backend methods related to vector and matrix norms #1520

Merged
merged 27 commits into from
Dec 19, 2024

Conversation

renatomello
Copy link
Contributor

@renatomello renatomello commented Nov 12, 2024

Closes #1518

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@renatomello renatomello added this to the Qibo 0.2.14 milestone Nov 12, 2024
@renatomello renatomello self-assigned this Nov 12, 2024
@renatomello
Copy link
Contributor Author

@MatteoRobbiati @BrunoLiegiBastonLiegi do you know what is this error in the tests regarding importing tensorflow from qiboml?

https://github.com/qiboteam/qibo/actions/runs/11794483631/job/32852177151?pr=1520

@BrunoLiegiBastonLiegi
Copy link
Contributor

Mmmh weird, but the tests under tensorflow are still running?

@MatteoRobbiati
Copy link
Contributor

I think what is strange is that it didn't fail before: tensorflow is no more a dependency, thus shouldn't this line always set tensorflow to False?

@scarrazza scarrazza modified the milestones: Qibo 0.2.14, Qibo 0.2.15 Nov 29, 2024
@@ -123,7 +123,7 @@ def test_list_available_backends():
"qibolab": False,
"qibo-cloud-backends": False,
"qibotn": {"cutensornet": False, "qutensornet": True},
"qiboml": {"tensorflow": False, "pytorch": True},
"qiboml": {"tensorflow": True, "pytorch": True},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the problem! This modification has to be removed. We need "tensorflow": False

Suggested change
"qiboml": {"tensorflow": True, "pytorch": True},
"qiboml": {"tensorflow": False, "pytorch": True},

@renatomello
Copy link
Contributor Author

renatomello commented Dec 10, 2024 via email

@MatteoRobbiati
Copy link
Contributor

It was like that before and it was passing on Windows and Mac but failing on Ubuntu.

I think because, for some reason, tensorflow is still a dependence here: see pyproject.toml. It has to be removed.

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.67%. Comparing base (ce6dc20) to head (ce0592f).
Report is 28 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1520   +/-   ##
=======================================
  Coverage   99.67%   99.67%           
=======================================
  Files          76       76           
  Lines       11234    11234           
=======================================
  Hits        11198    11198           
  Misses         36       36           
Flag Coverage Δ
unittests 99.67% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MatteoRobbiati MatteoRobbiati self-requested a review December 10, 2024 16:18
Copy link
Contributor

@MatteoRobbiati MatteoRobbiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@renatomello
Copy link
Contributor Author

Reminder that this PR needs merge coordination with the equivalent qibojit PR.

@MatteoRobbiati
Copy link
Contributor

MatteoRobbiati commented Dec 16, 2024

Reminder that this PR needs merge coordination with the equivalent qibojit PR.

Do you need reviewers in Qibojit? Feel free to add me in case

@renatomello
Copy link
Contributor Author

Reminder that this PR needs merge coordination with the equivalent qibojit PR.

Not needed after all, so I'm merging this PR.

@renatomello renatomello added this pull request to the merge queue Dec 19, 2024
Merged via the queue into master with commit 9fa2fb1 Dec 19, 2024
27 checks passed
@renatomello renatomello deleted the rename_methods branch December 19, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename backend methods related to norms
5 participants