-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming backend methods related to vector and matrix norms #1520
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
@MatteoRobbiati @BrunoLiegiBastonLiegi do you know what is this error in the tests regarding importing https://github.com/qiboteam/qibo/actions/runs/11794483631/job/32852177151?pr=1520 |
Mmmh weird, but the tests under tensorflow are still running? |
I think what is strange is that it didn't fail before: tensorflow is no more a dependency, thus shouldn't this line always set |
tests/test_backends.py
Outdated
@@ -123,7 +123,7 @@ def test_list_available_backends(): | |||
"qibolab": False, | |||
"qibo-cloud-backends": False, | |||
"qibotn": {"cutensornet": False, "qutensornet": True}, | |||
"qiboml": {"tensorflow": False, "pytorch": True}, | |||
"qiboml": {"tensorflow": True, "pytorch": True}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is the problem! This modification has to be removed. We need "tensorflow": False
"qiboml": {"tensorflow": True, "pytorch": True}, | |
"qiboml": {"tensorflow": False, "pytorch": True}, |
It was like that before and it was passing on Windows and Mac but failing
on Ubuntu.
…On Tue, 10 Dec 2024 at 19:19, Matteo Robbiati ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In tests/test_backends.py
<#1520 (comment)>:
> @@ -123,7 +123,7 @@ def test_list_available_backends():
"qibolab": False,
"qibo-cloud-backends": False,
"qibotn": {"cutensornet": False, "qutensornet": True},
- "qiboml": {"tensorflow": False, "pytorch": True},
+ "qiboml": {"tensorflow": True, "pytorch": True},
Here is the problem! This modification has to be removed. We need "tensorflow":
False
⬇️ Suggested change
- "qiboml": {"tensorflow": True, "pytorch": True},
+ "qiboml": {"tensorflow": False, "pytorch": True},
—
Reply to this email directly, view it on GitHub
<#1520 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABH5QVRNRFRIX73PSBR5LJT2E4BBZAVCNFSM6AAAAABRTIBE56VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIOJSGY3TQMZUHE>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
I think because, for some reason, |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1520 +/- ##
=======================================
Coverage 99.67% 99.67%
=======================================
Files 76 76
Lines 11234 11234
=======================================
Hits 11198 11198
Misses 36 36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Reminder that this PR needs merge coordination with the equivalent |
Do you need reviewers in Qibojit? Feel free to add me in case |
Not needed after all, so I'm merging this PR. |
Closes #1518
Checklist: