BUG: Empty samples #167
Merged
BUG: Empty samples #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We attempt to concatenate the empty samples dropped by dada2 in R back onto the table. If no samples are dropped we attempt to concat an empty 0x0 table onto the table produced by dada2 in R.
Bug introduced here
Came up on the forum here
Should be resolved by ensuring we have dropped samples before attempting to concat them back on.
OK so I went down a bit of a rabbit hole here, and the explanation is not actually as simple as I originally believed. The user on the forum specifically has 1 OTU and no dropped samples, so we try to instantiate a 1x0 biom table. We end up with a 0x0 biom table because of this line of code here. The guard I implemented in this PR should still work, but not quite for the reason I thought.