Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

增加 MakePrivateURLv2*() & MakePublicURLv2*() 系列方法来生成 escape 过的 key 的 url #20

Merged
merged 1 commit into from
Apr 22, 2021

Conversation

bachue
Copy link
Contributor

@bachue bachue commented Apr 20, 2021

No description provided.

@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #20 (ee1dfbb) into master (9ca7b05) will increase coverage by 0.14%.
The diff coverage is 54.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
+ Coverage   62.48%   62.62%   +0.14%     
==========================================
  Files          26       26              
  Lines        1930     1964      +34     
==========================================
+ Hits         1206     1230      +24     
- Misses        523      533      +10     
  Partials      201      201              
Impacted Files Coverage Δ
storage/bucket.go 55.32% <53.12%> (+1.18%) ⬆️
storage/token.go 64.00% <66.66%> (+3.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53d6a8a...ee1dfbb. Read the comment docs.

storage/bucket.go Outdated Show resolved Hide resolved
storage/bucket.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@YangSen-qn YangSen-qn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@bachue bachue force-pushed the features/make-url-with-escaped-key branch from a85e2ab to aee7171 Compare April 20, 2021 06:38
@bachue bachue changed the title 增加 MakePrivateURLv2() & MakePublicURLv2() 来生成 escape 过的 key 的 url 增加 MakePrivateURLv2*() & MakePublicURLv2*() 系列方法来生成 escape 过的 key 的 url Apr 20, 2021
storage/bucket.go Outdated Show resolved Hide resolved
storage/bucket_test.go Outdated Show resolved Hide resolved
@bachue bachue force-pushed the features/make-url-with-escaped-key branch 2 times, most recently from 0cea83e to 1cf3593 Compare April 21, 2021 07:31
@bachue bachue force-pushed the features/make-url-with-escaped-key branch from 1cf3593 to ee1dfbb Compare April 21, 2021 07:46
@e06084
Copy link
Contributor

e06084 commented Apr 21, 2021

lgtm

@Mei-Zhao Mei-Zhao merged commit bb7e742 into master Apr 22, 2021
@bachue bachue deleted the features/make-url-with-escaped-key branch August 6, 2021 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants