Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues using in Korean #16

Closed
JJay1 opened this issue May 1, 2023 · 6 comments
Closed

Issues using in Korean #16

JJay1 opened this issue May 1, 2023 · 6 comments

Comments

@JJay1
Copy link

JJay1 commented May 1, 2023

Please refer to the following link

https://imgur.com/a/LP9XMVU

  1. Typing "영어" searches only for bookmarks containing "영". You have to hit the space key once to completely search for bookmarks with "영어".
  2. As you can see, there is a question mark in place of a symbol indicating folders parent-child relations.

Thank you for your hard work.

@qinxs
Copy link
Owner

qinxs commented May 2, 2023

Regarding your question:

1 I have repeatedly looked at the frames associated with the gif you provided and found the problem;
Before you enter "영어" but not the space, the "어" character is still in the synthesis stage, so the actual search character is still "영".
Note the difference between the search characters in Figure 1 and Figure 2 (the "영" character is underlined)
001

2 This is how it is designed

  1. Open the subfolder from the parent directory list (the navigation bar symbol is ">")
  2. Open the folder from the list of search results (the navigation bar symbol is "?")

@JJay1
Copy link
Author

JJay1 commented May 2, 2023

12.webm

If you type "영어", as you said it is still recognized as a synthesis stage. Yeah, That's the problem. It should be recognized as a completed letter even if there is no adding space or right arrow key.

Here is another extension for an example.

In this extension, typing "영" will return results containing "영".
If you type "영어", you will get results that include "영어" (not "영") without pressing the space or right arrow key.
And it continues to stay in the underlined synthesis stage.

Whereas in Ease Bookmarks, hitting "영" doesn't produce anything.
Typing "영어" will return results containing "영" (should be "영어"). This is not the right way for Korean users.
The results should include all characters at any time, even without pressing the space or right arrow keys.
This is common thing with applications that have search features and google search has also fixed the problem in the past.

The extension used as an example is open source. I don't know much about coding, but I hope it helps you to look into the problem.

https://github.com/jamesrr39/chrome-bookmark-search
https://chrome.google.com/webstore/detail/bookmark-search/fcjphnojgeikgjajhlihdjnljnbpfhmi

@qinxs
Copy link
Owner

qinxs commented May 4, 2023

Okay, I'll learn more about the search effect of various other language requirements.

Later versions of the unified modification or add relevant configuration items

@qinxs
Copy link
Owner

qinxs commented May 28, 2023

Hello, this issue has been handled, please update it to the latest version (v1.6.2).

@JJay1
Copy link
Author

JJay1 commented May 29, 2023

I appreciate your work. I can see the issue fixed. But unfortunately, there's a problem that didn't exist in the previous version: you have to press space key three times to make a space. Please see the attached video.

123.mp4

@qinxs
Copy link
Owner

qinxs commented Apr 6, 2024

Sorry for the late reply.

Now you can set the hotkeyConfigTable in the
chrome-extension://jnlhiobkddpipmgjkpkhiefaahibkeke/options.html#configTable page,
change the value of hotkeyCancelSeleted:
from Space to -Space.

However, the search does not support space characters.

@qinxs qinxs closed this as completed Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants