-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrated quantum bayesian inference #717
Integrated quantum bayesian inference #717
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much for introducing this exciting feature! I've made a few surface-level suggestions, but I need to go through the method and tutorial in more detail to check my understanding of the implementation.
releasenotes/notes/add-quantum-bayesian-inference-92c6025432d9b7e0.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/add-quantum-bayesian-inference-92c6025432d9b7e0.yaml
Outdated
Show resolved
Hide resolved
…b7e0.yaml Co-authored-by: Steve Wood <[email protected]>
…b7e0.yaml Co-authored-by: Steve Wood <[email protected]>
Co-authored-by: Declan Millar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to re-run CI tests with the most up-to-date dev branch just before merging. Looking forward to having Bayesian methods in the codebase!
I'm not even sure I can, but should I merge it or do you? |
I would be happy to go ahead, but I would like to hear the opinions of @woodsp-ibm and @OkuyanBoga. Do you think this is a good time to merge? |
It seems fine to me given the expectation that this feature will be in the next main release. |
Thank you all, I merged it after the approvals. |
Summary
This pull request introduces the QBayesian class to the Qiskit Machine Learning library. The class implements the Quantum Bayesian Inference algorithm, providing a quantum-based approach to infer probabilities in Bayesian networks. This enhancement aligns with the ongoing efforts to expand the library's capabilities in quantum machine learning algorithms. The algorithm is based on the paper from Low, Guang Hao, Theodore J. Yoder, and Isaac L. Chuang. "Quantum inference on Bayesian networks", Physical Review A 89.6 (2014): 062315.
Details and comments
✅ I have added the tests to cover my changes.
✅ I have updated the documentation accordingly.
✅ I have read the CONTRIBUTING document.