Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the deprecated code stack from prior to version 0.5 #1142

Merged
merged 18 commits into from
Apr 27, 2023

Conversation

mrossinek
Copy link
Member

@mrossinek mrossinek commented Apr 26, 2023

Summary

This is THE PR which removes all of the legacy code from how the stack prior to version 0.5 used to work.

Details and comments

  • Reno with upgrade section for this removal

@mrossinek
Copy link
Member Author

Qiskit Neko will continue to fail until Qiskit/qiskit-neko#21 gets merged

@mrossinek mrossinek marked this pull request as ready for review April 26, 2023 19:30
@coveralls
Copy link

coveralls commented Apr 26, 2023

Pull Request Test Coverage Report for Build 4823738867

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+1.3%) to 87.183%

Files with Coverage Reduction New Missed Lines %
qiskit_nature/second_q/formats/qcschema/qc_schema.py 1 73.33%
Totals Coverage Status
Change from base Build 4813651887: 1.3%
Covered Lines: 9108
Relevant Lines: 10447

💛 - Coveralls

Copy link
Member

@woodsp-ibm woodsp-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪦 In memoriam for our dearly deprecated code. taken so soon from our codebase, never to bug us again.

@mrossinek mrossinek merged commit 5aee55d into qiskit-community:main Apr 27, 2023
@mrossinek mrossinek deleted the remove-legacy-code branch April 27, 2023 20:22
garrison added a commit to Qiskit/qiskit-addon-cutting that referenced this pull request Apr 28, 2023
Now that qiskit-community/qiskit-nature#1142 has been merged, our "development version tests" are going to fail on `main` until #83 is merged.  This change fixes CI immediately by excluding the development version of qiskit-nature from these tests.  This change should be reverted as part of #83 before it is merged.
garrison added a commit to Qiskit/qiskit-addon-cutting that referenced this pull request Apr 28, 2023
Now that qiskit-community/qiskit-nature#1142 has been merged, our "development version tests" are going to fail on `main` until #83 is merged.  This change fixes CI immediately by excluding the development version of qiskit-nature from these tests.  This change should be reverted as part of #83 before it is merged.
Anthony-Gandon pushed a commit to Anthony-Gandon/qiskit-nature that referenced this pull request May 25, 2023
…mmunity#1142)

* Remove the deprecated code stack from prior to version 0.5

* fix: runtime unittests

* docs: convert old migration jupyter notebooks to rst files

* fix: testing module

* Fix copyright

* Remove deprecated ListOrDict class

* fix: QCSchema unittest

* Add release note

* More copyright fixes

* Fix lint

* Remove scikit-learn from requirements

* Remove unneeded deprecation warnings from RST files

* Remove settings.dict_aux_operators

* Fix lint

* Fix docs of qiskit_nature.testing module

* Fix copyright
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants