-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the deprecated code stack from prior to version 0.5 #1142
Merged
mrossinek
merged 18 commits into
qiskit-community:main
from
mrossinek:remove-legacy-code
Apr 27, 2023
Merged
Remove the deprecated code stack from prior to version 0.5 #1142
mrossinek
merged 18 commits into
qiskit-community:main
from
mrossinek:remove-legacy-code
Apr 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qiskit Neko will continue to fail until Qiskit/qiskit-neko#21 gets merged |
Pull Request Test Coverage Report for Build 4823738867
💛 - Coveralls |
woodsp-ibm
approved these changes
Apr 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🪦 In memoriam for our dearly deprecated code. taken so soon from our codebase, never to bug us again.
garrison
added a commit
to Qiskit/qiskit-addon-cutting
that referenced
this pull request
Apr 28, 2023
Now that qiskit-community/qiskit-nature#1142 has been merged, our "development version tests" are going to fail on `main` until #83 is merged. This change fixes CI immediately by excluding the development version of qiskit-nature from these tests. This change should be reverted as part of #83 before it is merged.
garrison
added a commit
to Qiskit/qiskit-addon-cutting
that referenced
this pull request
Apr 28, 2023
Now that qiskit-community/qiskit-nature#1142 has been merged, our "development version tests" are going to fail on `main` until #83 is merged. This change fixes CI immediately by excluding the development version of qiskit-nature from these tests. This change should be reverted as part of #83 before it is merged.
Anthony-Gandon
pushed a commit
to Anthony-Gandon/qiskit-nature
that referenced
this pull request
May 25, 2023
…mmunity#1142) * Remove the deprecated code stack from prior to version 0.5 * fix: runtime unittests * docs: convert old migration jupyter notebooks to rst files * fix: testing module * Fix copyright * Remove deprecated ListOrDict class * fix: QCSchema unittest * Add release note * More copyright fixes * Fix lint * Remove scikit-learn from requirements * Remove unneeded deprecation warnings from RST files * Remove settings.dict_aux_operators * Fix lint * Fix docs of qiskit_nature.testing module * Fix copyright
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is THE PR which removes all of the legacy code from how the stack prior to version 0.5 used to work.
Details and comments