fix: typing compatibility with rustworkx 0.13.0 #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrossinek
added
priority: critical
stable backport potential
This change should be reverted once rustworkx 0.13.1 has fixed this typing incompatibility.
Pull Request Test Coverage Report for Build 5209060114
💛 - Coveralls |
woodsp-ibm
reviewed
Jun 8, 2023
| @@ -217,7 +217,14 @@ jobs: | |||
| source "$CONDA/etc/profile.d/conda.sh" | |||
| conda activate psi4env | |||
| make mypy | |||
There was a problem hiding this comment.
I imagine you could have done a simple if else around the make mypy to do it one way or another depending on whether python version was 3.7 or not - akin to what is done in line 176 above. But this does the job too.
There was a problem hiding this comment.
Ha I failed to see that other example and simply zoomed in on the local part here and this seemed good enough 👍
woodsp-ibm
approved these changes
Jun 8, 2023
mergify bot
pushed a commit
that referenced
this pull request
Jun 8, 2023
* fix: typing compatibility with rustworkx 0.13.0 * fix: update copyright * hotfix: avoid mypy warning about unused ignores This change should be reverted once rustworkx 0.13.1 has fixed this typing incompatibility. (cherry picked from commit 08df681)
This was referenced Jun 8, 2023
mergify bot
added a commit
that referenced
this pull request
Jun 8, 2023
* fix: typing compatibility with rustworkx 0.13.0 (#1202) * fix: typing compatibility with rustworkx 0.13.0 * fix: update copyright * hotfix: avoid mypy warning about unused ignores This change should be reverted once rustworkx 0.13.1 has fixed this typing incompatibility. (cherry picked from commit 08df681) * fix: backport mypy updates to legacy code locations --------- Co-authored-by: Max Rossmannek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Makes mypy happy due to the new typing support of rustworkx 0.13.0
So far, this is only a partial typing support which mypy does not seem to pick up on, despite https://github.com/Qiskit/rustworkx/blob/58fdd933cd81c576a3cc02c8a6b7b4e4646ea9c3/rustworkx/py.typed#L1
Details and comments
The constraint for Python 3.7 is due to Qiskit/rustworkx#893