ci: update deploy-docs authorized users #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to deploy the documentation to the public URL, a Github action needs to be triggered manually. In order to avoid anyone being able to do this, the script which is being run asserts the username of the `github.actor` to be in a hard-coded list of authorized users. This commit updates this list in accordance with the recent CODEOWNER changes. I believe, that there must be a better way to handle/restrict access to who can trigger this action, but for the time being I will simply do this quick fix.
mrossinek
requested review from
woodsp-ibm,
robertodr and
matteoacrossi
as code owners
mrossinek
added
the
stable backport potential
woodsp-ibm
approved these changes
Nov 27, 2023
Pull Request Test Coverage Report for Build 7006993017
💛 - Coveralls |
mergify bot
pushed a commit
that referenced
this pull request
Nov 27, 2023
In order to deploy the documentation to the public URL, a Github action needs to be triggered manually. In order to avoid anyone being able to do this, the script which is being run asserts the username of the `github.actor` to be in a hard-coded list of authorized users. This commit updates this list in accordance with the recent CODEOWNER changes. I believe, that there must be a better way to handle/restrict access to who can trigger this action, but for the time being I will simply do this quick fix. (cherry picked from commit 4ce231e)
mergify bot
added a commit
that referenced
this pull request
Nov 27, 2023
In order to deploy the documentation to the public URL, a Github action needs to be triggered manually. In order to avoid anyone being able to do this, the script which is being run asserts the username of the `github.actor` to be in a hard-coded list of authorized users. This commit updates this list in accordance with the recent CODEOWNER changes. I believe, that there must be a better way to handle/restrict access to who can trigger this action, but for the time being I will simply do this quick fix. (cherry picked from commit 4ce231e) Co-authored-by: Max Rossmannek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In order to deploy the documentation to the public URL, a Github action needs to be triggered manually. In order to avoid anyone being able to do this, the script which is being run asserts the username of the
github.actorto be in a hard-coded list of authorized users.This commit updates this list in accordance with the recent CODEOWNER changes.
I believe, that there must be a better way to handle/restrict access to who can trigger this action, but for the time being I will simply do this quick fix.
Details and comments