fix: do not use normal_order as part of commutator methods
#1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrossinek
added
the
stable backport potential
mrossinek
requested review from
woodsp-ibm,
robertodr,
matteoacrossi and
ftroisi
as code owners
mrossinek
force-pushed
the
fix-commutators
branch
from
b15eb12 to
ac66d86
Compare
robertodr
previously approved these changes
Dec 7, 2023
ftroisi
reviewed
Dec 7, 2023
Pull Request Test Coverage Report for Build 7125855649
💛 - Coveralls |
ftroisi
approved these changes
Dec 7, 2023
|
Sorry, looks like we got into a race on requesting a review and approving. Please re-approve 😅 |
ftroisi
approved these changes
Dec 7, 2023
robertodr
approved these changes
Dec 7, 2023
mergify bot
added a commit
that referenced
this pull request
Dec 7, 2023
…1300) * fix: do not use `normal_order` as part of commutator methods Fixes #1298 * Update docs (cherry picked from commit 978fcad) Co-authored-by: Max Rossmannek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1298
Details and comments
In #1208 we had discussed the inclusion of
normal_orderinto the commutator methods without realizing that this breaks API. Here, I simply remove this call and update the unittests accordingly.Basically, this means that the user needs to normal-order the result themselves if needed (which is totally fine).