fix: make FermionicOp.simplify preserve the term order #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrossinek
requested review from
stefan-woerner,
manoelmarques and
woodsp-ibm
as code owners
Pull Request Test Coverage Report for Build 3263501670
💛 - Coveralls |
woodsp-ibm
approved these changes
Oct 17, 2022
kevinsung
reviewed
Oct 18, 2022
| @@ -84,7 +84,7 @@ def test_compose(self): | |||
| ) @ FermionicOp({"": 1, "-_0 +_1": 1}, num_spin_orbitals=2) | |||
| fer_op = fer_op.simplify() | |||
| targ = FermionicOp( | |||
| {"+_0 +_1 -_1": 1, "-_0 +_0 -_1": 1, "+_0 -_0 +_1": 1, "-_0 -_1 +_1": -1}, | |||
| {"+_0 +_1 -_1": 1, "-_0 +_0 -_1": 1, "+_0 +_1 -_0": 1, "-_0 -_1 +_1": -1}, | |||
There was a problem hiding this comment.
You swapped the order of the terms here, but you didn't add a minus sign.
There was a problem hiding this comment.
Thanks for spotting this! #900 should address this bug 👍
This was referenced Oct 18, 2022
Anthony-Gandon
pushed a commit
to Anthony-Gandon/qiskit-nature
that referenced
this pull request
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #888
Details and comments