feat: implement Fermionic.index_order
#902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrossinek
requested review from
stefan-woerner,
manoelmarques and
woodsp-ibm
as code owners
Pull Request Test Coverage Report for Build 3282832855
💛 - Coveralls |
This also renames FermionicOp.normal_ordered to FermionicOp.normal_order, aligning the naming convention of using verbs for method names which act on one or more operators without transforming it to or from another type. Closes qiskit-community#901
mrossinek
force-pushed
the
fermionicop-index-ordered
branch
from
2c3bc47 to
a530767
Compare
mrossinek
changed the title
Fermionic.index_orderedFermionic.index_order
woodsp-ibm
approved these changes
Oct 19, 2022
Anthony-Gandon
pushed a commit
to Anthony-Gandon/qiskit-nature
that referenced
this pull request
May 25, 2023
This also renames FermionicOp.normal_ordered to FermionicOp.normal_order, aligning the naming convention of using verbs for method names which act on one or more operators without transforming it to or from another type. Closes qiskit-community#901
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Instead of going with my original proposal in #901, I went for a more modular approach by implementing a method which performs the index ordering of a
FermionicOp. This can then be combined together with.simplify()to achieve "maximum" simplification.Details and comments
Closes #901