Fix #138

qiuxiang · Dec 23, 2017 · 7590b12 · 7590b12
1 parent 675efab
commit 7590b12
Show file tree

Hide file tree

Showing 9 changed files with 38 additions and 32 deletions.
diff --git a/ios/maps/AMapCallout.h b/ios/maps/AMapCallout.h
@@ -0,0 +1,4 @@
+#import <React/RCTView.h>
+
+@interface AMapCallout : RCTView
+@end
diff --git a/ios/maps/AMapCallout.m b/ios/maps/AMapCallout.m
@@ -0,0 +1,4 @@
+#import "AMapCallout.h"
+
+@implementation AMapCallout
+@end
diff --git a/ios/maps/AMapCalloutManager.m b/ios/maps/AMapCalloutManager.m
@@ -0,0 +1,18 @@
+#import <React/RCTUIManager.h>
+#import "AMapCallout.h"
+
+#pragma ide diagnostic ignored "OCUnusedClassInspection"
+
+@interface AMapCalloutManager : RCTViewManager
+@end
+
+@implementation AMapCalloutManager {
+}
+
+RCT_EXPORT_MODULE(AMapInfoWindow)
+
+- (UIView *)view {
+    return [AMapCallout new];
+}
+
+@end
diff --git a/ios/maps/AMapInfoWindow.h b/ios/maps/AMapInfoWindow.h
diff --git a/ios/maps/AMapInfoWindow.m b/ios/maps/AMapInfoWindow.m
diff --git a/ios/maps/AMapInfoWindowManager.m b/ios/maps/AMapInfoWindowManager.m
diff --git a/ios/maps/AMapMarker.h b/ios/maps/AMapMarker.h
@@ -1,5 +1,5 @@
 #import "AMapView.h"
-#import "AMapInfoWindow.h"
+#import "AMapCallout.h"
 
 @interface AMapMarker : UIView
 

diff --git a/ios/maps/AMapMarker.m b/ios/maps/AMapMarker.m
@@ -2,6 +2,7 @@
 #import "AMapMarker.h"
 
 #pragma ide diagnostic ignored "OCUnusedMethodInspection"
+#pragma clang diagnostic ignored "-Woverriding-method-mismatch"
 
 @implementation AMapMarker {
     MAPointAnnotation *_annotation;
@@ -11,9 +12,10 @@ @implementation AMapMarker {
     AMapView *_mapView;
     MAPinAnnotationColor _pinColor;
     UIImage *_image;
-    BOOL _draggable;
     CGPoint _centerOffset;
+    BOOL _draggable;
     BOOL _active;
+    BOOL _canShowCallout;
 }
 
 - (instancetype)init {
@@ -53,7 +55,6 @@ - (void)setCenterOffset:(CGPoint)centerOffset {
     _annotationView.centerOffset = centerOffset;
 }
 
-#pragma clang diagnostic ignored "-Woverriding-method-mismatch"
 - (void)setImage:(NSString *)name {
     _image = [UIImage imageNamed:name];
     if (_image != nil) {
@@ -83,6 +84,7 @@ - (void)setClickable:(BOOL)enabled {
 }
 
 - (void)setInfoWindowEnabled:(BOOL)enabled {
+    _canShowCallout = enabled;
     _annotationView.canShowCallout = enabled;
 }
 
@@ -101,6 +103,7 @@ - (void)_handleTap:(UITapGestureRecognizer *)recognizer {
 - (MAAnnotationView *)annotationView {
     if (_annotationView == nil) {
         if (_customView) {
+            _customView.hidden = NO;
             _annotationView = [[MAAnnotationView alloc] initWithAnnotation:_annotation reuseIdentifier:nil];
             _annotationView.bounds = _customView.bounds;
             [_annotationView addSubview:_customView];
@@ -110,7 +113,7 @@ - (MAAnnotationView *)annotationView {
             _annotationView = [[MAPinAnnotationView alloc] initWithAnnotation:_annotation reuseIdentifier:nil];
             ((MAPinAnnotationView *) _annotationView).pinColor = _pinColor;
         }
-        _annotationView.canShowCallout = YES;
+        _annotationView.canShowCallout = _canShowCallout;
         _annotationView.draggable = _draggable;
         _annotationView.customCalloutView = _calloutView;
         _annotationView.centerOffset = _centerOffset;
@@ -123,11 +126,12 @@ - (MAAnnotationView *)annotationView {
 }
 
 - (void)didAddSubview:(UIView *)subview {
-    if ([subview isKindOfClass:[AMapInfoWindow class]]) {
+    if ([subview isKindOfClass:[AMapCallout class]]) {
         _calloutView = [[MACustomCalloutView alloc] initWithCustomView:subview];
         _annotationView.customCalloutView = _calloutView;
     } else {
         _customView = subview;
+        _customView.hidden = YES;
     }
 }
 

diff --git a/ios/maps/AMapView.m b/ios/maps/AMapView.m
@@ -53,7 +53,9 @@ - (void)didAddSubview:(UIView *)subview {
         AMapMarker *marker = (AMapMarker *) subview;
         marker.mapView = self;
         _markers[[@(marker.annotation.hash) stringValue]] = marker;
-        [self addAnnotation:marker.annotation];
+        dispatch_async(dispatch_get_main_queue(), ^{
+            [self addAnnotation:marker.annotation];
+        });
     }
     if ([subview isKindOfClass:[AMapOverlay class]]) {
         [self addOverlay:(id <MAOverlay>) subview];