Fujitsu T111 keyboard

[DmNosachev]

New keyboard: Fujitsu N860-2500-T111
QMK-conversion by directly connecting to the existing matrix

Types of Changes

• Core
• Bugfix
• New feature
• Enhancement/optimization
• Keyboard (addition or update)
• Keymap/layout/userspace (addition or update)
• Documentation

Issues Fixed or Closed by This PR

Checklist

• My code follows the code style of this project: C, Python
• I have read the PR Checklist document and have made the appropriate changes.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• I have tested the changes and verified that they work and don't break anything (as well as I can manage).

[noroadsleft]

GitHub tip: You can apply multiple suggestions to a single commit by using the Files Changed tab.

[noroadsleft]

It seems the re-request for reviews may have marked my review comments as resolved, but the issues I flagged are still outstanding. Was that deliberate?

[DmNosachev]

It seems the re-request for reviews may have marked my review comments as resolved, but the issues I flagged are still outstanding. Was that deliberate?

Sorry, that's because I don't know much about how GitHub's UI handles pull requests. I have marked all your suggested changes as Resolved and thought that it makes them to be applied automatically. But I still can see noroadsleft requested changes on the bottom of the page and can't find any other buttons and/or links to agree with proposed changes.

[noroadsleft]

Sorry, that's because I don't know much about how GitHub's UI handles pull requests. I have marked all your suggested changes as Resolved and thought that it makes them to be applied automatically. But I still can see noroadsleft requested changes on the bottom of the page and can't find any other buttons and/or links to agree with proposed changes.

Okay, there's a couple different systems at play here:

• Marking a conversation as resolved:
  "I have completed the requested action."
• [user] requested changes:
  You see this when a reviewer requests changes, up until the point that user changes the status of their request. They may request more changes, or approve the changes you've made.

When you have changes requested, you'll see something like this:

You can commit that suggestion by clicking the button, but if you go to the Files Changed tab, you gain access to the Add suggestion to batch feature:

Instead of committing that change directly, it adds that suggestion to a queue, where all the suggestions you add to the queue can be committed at once. (I sort of selfishly prefer this because it saves CPU cycles on our CI infrastructure.)

I've unresolved my previous review comments. I don't recall if committing the suggestions (individually or in a batch) marks the conversations as resolved automatically or not, but I'll review them anyway when the PR updates.

Hope this helps.

[noroadsleft]

Missed one, but you found the right buttons. 🙂

[noroadsleft]

Thanks!