[Keyboard] Concertina

[veikman]

A novel handwired keyboard.

Description

For a general description with photos, see https://viktor.eikman.se/article/the-concertina/.

It’s the physical shape that’s new. No major customizations have been made to the firmware.

I would like to provide Configurator support, but because the shape is highly three-dimensional, info.json is incomplete and self-contradictory in this PR. I have found this tool and this guide but a meaningful info.json would seem to require getting a local instance of Configurator up and running just to see how the visualization would eventually be rendered as I hand-craft the offsets. If I should I be doing that, please let me know.

Types of Changes

• Core
• Bugfix
• New feature
• Enhancement/optimization
• Keyboard (addition or update)
• Keymap/layout/userspace (addition or update)
• Documentation

Checklist

• My code follows the code style of this project
• I have read the PR Checklist document and have made the appropriate changes except info.json, which is incomplete.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• I have tested the changes and verified that they work and don't break anything (as well as I can manage).

[veikman]

The second commit has a stubbed-out info.json that is probably going to look bad and be useless, partly because it is not clear to me how the order of the JSON layout maps to the C macro, partly because I have not previewed how Configurator will render it. It does pass lint checks though.

[veikman]

Thank you for the review and merge, but I would still be interested to know how to preview Configurator layouts before submitting a PR. Right now, Configurator shows no known layouts for the board. I guess I have failed somehow, but I don’t know where to start looking to fix this.

[noroadsleft]

@veikman,

Thank you for the review and merge, but I would still be interested to know how to preview Configurator layouts before submitting a PR.

You can preview info.json files by opening QMK Configurator in your web browser and hitting Ctrl+Shift+I, in that order.

Right now, Configurator shows no known layouts for the board. I guess I have failed somehow, but I don’t know where to start looking to fix this.

Your submitted directory structure is wrong. You have source split between the handwired/concertina and handwired/concertina/64key directories. This isn't a problem on its own, but the 64key directory has no rules.mk file, the existence of which is required for QMK's Makefile to understand that this is a keyboard that can be compiled. You have a rules.mk file in handwired/concertina, but no keymaps folder therein, so make handwired/concertina fails because it can't find your layout macro LAYOUT_64key or any keymaps.

This block

qmk_firmware/keyboards/handwired/concertina/concertina.h

Lines 19 to 21 in 11146ec

	#ifdef KEYBOARD_handwired_concertina_64key
	#include "64key.h"
	#endif

is never true because there is no keyboards/handwired/concertina/64key/rules.mk file, so KEYBOARD_handwired_concertina_64key is never defined.

I've posted a compilation fix at #11987. Would appreciate your attention there regarding the Configurator implementation, which I'm not sure is correct at this time.